New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert `src/backend/hashes.rs` to new pyo3 APIs #10705

Merged

alex merged 1 commit into pyca:main from trail-of-forks:pyo3-bound-hashes

Apr 4, 2024

Contributor

facutuesca commented Apr 4, 2024

Part of #10676. This fixes all of the warnings in src/backend/hashes.rs.

Most of the changes are trivial, but there are a couple where I added a clone() call that should be manually reviewed:

In hashes.rs:97:

algorithm: algorithm.clone().into_py(py),

In rsa.rs:294:

algorithm.clone().into_gil_ref(),

In rsa.rs:444:

algorithm.clone().into_gil_ref(),

cc @alex @reaperhulk


          Convert src/backend/hashes.rs to new pyo3 APIs

50aecf3

alex approved these changes

View reviewed changes

alex merged commit 01d27ac into pyca:main

58 checks passed

facutuesca deleted the pyo3-bound-hashes branch

April 4, 2024 12:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet