Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gil-refs feature for pyo3 #10676

Closed
51 tasks done
alex opened this issue Apr 1, 2024 · 2 comments
Closed
51 tasks done

Remove gil-refs feature for pyo3 #10676

alex opened this issue Apr 1, 2024 · 2 comments

Comments

@alex
Copy link
Member

alex commented Apr 1, 2024

This requires fixing hundreds of warnings. Ideally we will do this in many small PRs, perhaps file at a time.

If you're interested in contributing:

  • Edit src/rust/Cargo.toml to remove the gil-refs feature
  • Try compiling (nox -e local)
  • Fix an error
  • Send a PR!

Progress:

  • 4/3: 5 previous errors; 531 warnings emitted
  • 4/4: 5 previous errors; 359 warnings emitted
  • 4/5: 3 previous errors; 105 warnings emitted
  • 4/6: 25 previous errors; 1 warning emitted

Phase 1

Preview Give feedback

Cleanup

Preview Give feedback
@alex alex added this to the Forty Third Release milestone Apr 1, 2024
alex added a commit to alex/cryptography that referenced this issue Apr 2, 2024
@alex
Copy link
Member Author

alex commented Apr 15, 2024

We're done here!

@alex alex closed this as completed Apr 15, 2024
@davidhewitt
Copy link

Great! Seems like I can release PyO3 0.21.2 without needing further changes!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants