Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate more x509/extensions.rs APIs to new pyo3 APIs (and other migrations) #10749

Merged
merged 3 commits into from
Apr 5, 2024
Merged

Migrate more x509/extensions.rs APIs to new pyo3 APIs (and other migrations) #10749

merged 3 commits into from
Apr 5, 2024

Conversation

facutuesca
Copy link
Contributor

Part of #10676

This one does not fix any warnings, but it does remove multiple into_gil_ref() calls and migrates several functions to use Bound parameters.

cc @alex @reaperhulk

alex
alex reviewed Apr 5, 2024
View reviewed changes
src/rust/src/x509/certificate.rs Outdated
Comment on lines 108 to 110
.as_borrowed()
.to_owned(),
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure you can drop these.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, fixed!

@alex alex enabled auto-merge (squash) April 5, 2024 21:40
@alex alex merged commit 2e345f2 into pyca:main Apr 5, 2024
58 checks passed
@facutuesca facutuesca deleted the misc-pyo3-cleanups branch April 5, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex alex alex approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@facutuesca @alex