Convert src/x509/crl.rs to new pyo3 APIs

[facutuesca]

This PR should be merged after this other PR: #10734

Part of #10676

This fixes all of the migration warnings for src/x509/crl.rs, after taking into account the ones fixed by #10734.

cc @alex @reaperhulk

[facutuesca]

Huh there's an import in crl.rs:

use pyo3::PyNativeType,

that I need in order to build locally. But on the GitHub CI, it fails on some workflows saying the import is unused. And when I push a commit removing the import, all of the CI workflows pass except for the ReadTheDocs build, which fails with the same error I get locally:

      error[E0599]: no method named `as_borrowed` found for reference `&PyAny` in the current scope
         --> src/x509/crl.rs:272:18
          |
      271 |               Some(t) => Ok(x509::datetime_to_py(py, t.as_datetime())?
          |  ___________________________-
      272 | |                 .as_borrowed()
          | |                 -^^^^^^^^^^^ method not found in `&PyAny`
          | |_________________|
          |
          |
          = help: items from traits can only be used if the trait is in scope
      help: the following trait is implemented but not in scope; perhaps add a `use` for it:
          |
      5   + use pyo3::PyNativeType;

[alex]

Is this rebased on main?

[facutuesca]

Is this rebased on main?

no, it's on top of your sign-bound branch

[facutuesca]

Ah does the checkout action on CI merge the commits from the PR with the latest main?

[alex]

Yeah, it uses the "merge commit that would exist between the PR and the target branch"

…

On Fri, Apr 5, 2024 at 12:21 PM Facundo Tuesca ***@***.***> wrote: Ah does the checkout action on CI merge the commits from the PR with the latest main? — Reply to this email directly, view it on GitHub <#10744 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAAGBC6OVSAEP5XB23CPKTY33FO3AVCNFSM6AAAAABFZLUW4GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBQGIYDKMRWG4> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- All that is necessary for evil to succeed is for good people to do nothing.

[alex]

You should be good to rebase