Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert private_bytes methods to new pyo3 APIs #10707

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

facutuesca
Copy link
Contributor

Part of #10676

Converts pkey_private_bytes() in utils.rs, along with all of the private_bytes() methods using it.
There's also an extra migration for rsa.rs, which needs manual review:

// rsa.rs:150
// before
.extract::<Option<&[u8]>>()?
// after
.extract::<Option<pyo3::pybacked::PyBackedBytes>>()?

cc @alex @reaperhulk

@alex alex enabled auto-merge (squash) April 4, 2024 13:47
@alex
Copy link
Member

alex commented Apr 4, 2024

Some failing tests, ptal

@facutuesca
Copy link
Contributor Author

Some failing tests, ptal

I can't reproduce locally, and the GH Action logs only show:

image

I'll trigger another run to see if anything changes

auto-merge was automatically disabled April 4, 2024 14:17

Head branch was pushed to by a user without write access

@facutuesca facutuesca force-pushed the private-bytes-to-bound branch from e26b25c to d6d484b Compare April 4, 2024 14:17
@alex
Copy link
Member

alex commented Apr 4, 2024 via email

@alex alex merged commit 52bed48 into pyca:main Apr 4, 2024
58 checks passed
@facutuesca facutuesca deleted the private-bytes-to-bound branch April 4, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants