Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc oscp pyo3 migrations #10748

Merged
merged 2 commits into from
Apr 5, 2024
Merged

Conversation

facutuesca
Copy link
Contributor

Part of #10676

This contains misc migrations for the ocsp files and pkcs7. One of the changes triggers a pretty big cargo fmt change in pkcs7.rs making the diff very difficult to read, so I split that change into a second commit.
The only thing that actually changes in the second commit is:

// pkcs7.rs:165
// before
let digest = asn1::write_single(&x509::ocsp::hash_data(py, py_hash_alg, &data_with_header)?)?;

// after
let digest = asn1::write_single(&x509::ocsp::hash_data(py, &py_hash_alg.as_borrowed(), &data_with_header)?)?;

the rest is all formatting.

I suggest reviewing the first commit normally, and then the second to check the above change.

cc @alex @reaperhulk

@alex alex enabled auto-merge (squash) April 5, 2024 20:30
@facutuesca
Copy link
Contributor Author

Ah this also removes the last of the ocsp_resp.rs warnings

@alex alex merged commit 5b50868 into pyca:main Apr 5, 2024
58 checks passed
@facutuesca facutuesca deleted the misc-oscp-pyo3-migrations branch April 5, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants