Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unify 'profile.profiling' configuration #1158

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Conversation

davidhewitt
Copy link
Contributor

Change Summary

Just makes things a bit more uniform in how configuration is applied for profiling locally & on codspeed.

Related issue number

N/A

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Copy link
Member

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidhewitt davidhewitt enabled auto-merge (squash) January 15, 2024 10:19
@davidhewitt davidhewitt merged commit b9b28ad into main Jan 15, 2024
26 checks passed
@davidhewitt davidhewitt deleted the dh/cargo-profiling branch January 15, 2024 10:24
Copy link

codspeed-hq bot commented Jan 15, 2024

CodSpeed Performance Report

Merging #1158 will degrade performances by 13.59%

Comparing dh/cargo-profiling (deb1b1b) with main (fa65fcd)

Summary

⚡ 2 improvements
❌ 1 regressions
✅ 139 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main dh/cargo-profiling Change
test_small_class_core_model 50.5 µs 58.4 µs -13.59%
test_core_future_str 39 µs 31.5 µs +24.03%
test_tuple_many_variable 43.3 µs 33.6 µs +28.83%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants