Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct build-profiling make command #1160

Merged
merged 1 commit into from
Jan 15, 2024
Merged

correct build-profiling make command #1160

merged 1 commit into from
Jan 15, 2024

Conversation

davidhewitt
Copy link
Contributor

Change Summary

Fix typo from #1158

Related issue number

N/A

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@samuelcolvin samuelcolvin enabled auto-merge (squash) January 15, 2024 10:50
@samuelcolvin samuelcolvin merged commit 5d3aa43 into main Jan 15, 2024
25 checks passed
@samuelcolvin samuelcolvin deleted the dh/fix-typo branch January 15, 2024 10:55
Copy link

codspeed-hq bot commented Jan 15, 2024

CodSpeed Performance Report

Merging #1160 will degrade performances by 20.09%

Comparing dh/fix-typo (55bfced) with main (5791667)

Summary

❌ 3 regressions
✅ 139 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main dh/fix-typo Change
test_core_future_str 31.6 µs 39.5 µs -20.08%
test_core_future 29.7 µs 37.2 µs -20.09%
test_core_str 31.2 µs 38.8 µs -19.5%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants