associated types for arguments in Input #1234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
commented
Mar 19, 2024
| Self: 'a; | ||
| fn len(&self) -> usize; | ||
| fn get_item<'k>(&self, key: &'k LookupKey) -> ValResult<Option<(&'k LookupPath, Self::Item<'_>)>>; | ||
| fn iter(&self) -> impl Iterator<Item = ValResult<(Self::Key<'_>, Self::Item<'_>)>>; |
There was a problem hiding this comment.
It's the return-position-impl-trait-in-trait which requires Rust 1.76 for the MSRV bump. If we wanted to avoid that we probably can use associated types but it'll be gross by comparison (or we can Box and suffer an allocation).
CodSpeed Performance ReportMerging #1234 will not alter performanceComparing Summary
|
samuelcolvin
approved these changes
Mar 19, 2024
| pos_value = $get_macro!(args, index); | ||
| } | ||
| // go through fields getting the value from args or kwargs and validating it | ||
| for (index, field) in self.fields.iter().enumerate() { |
There was a problem hiding this comment.
it's pretty hard to review but I assume very little changed here.
There was a problem hiding this comment.
Yep if you hide whitespace from the diff it's a lot easier to see what changed.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Continuing with #1230
This time we move
GenericArgumentsto have associated types.Related issue number
N/A
Checklist
pydantic-core(except for expected changes)