Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

associated types for dict in input #1237

Merged
merged 2 commits into from
Mar 20, 2024
Merged

associated types for dict in input #1237

merged 2 commits into from
Mar 20, 2024

Conversation

davidhewitt
Copy link
Contributor

Change Summary

Continuing from #1230, #1234, now we replace GenericMapping with associated types for each Input implementation.

Related issue number

N/A

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Mar 19, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #1237 will not alter performance

Comparing dh/input-assocs (50153be) with main (abff9ba)

Summary

✅ 148 untouched benchmarks

samuelcolvin
samuelcolvin approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing LGTM!

@davidhewitt davidhewitt enabled auto-merge (squash) March 20, 2024 10:28
@davidhewitt davidhewitt merged commit 36a1b6c into main Mar 20, 2024
27 checks passed
@davidhewitt davidhewitt deleted the dh/input-assocs branch March 20, 2024 10:34
@davidhewitt davidhewitt mentioned this pull request Mar 20, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelcolvin samuelcolvin samuelcolvin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidhewitt @samuelcolvin