Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remaining associated types #1238

Merged
merged 2 commits into from
Mar 20, 2024
Merged

remaining associated types #1238

merged 2 commits into from
Mar 20, 2024

Conversation

davidhewitt
Copy link
Contributor

Change Summary

Continues #1237 even further, this time we remove GenericIterable completely and make tuple, set, and frozenset associated types.

While working on this I cut down significantly the number of types in the reworked GenericIterable enum. Based on the live code paths this should be functionally equivalent but hopefully have a smaller binary (or just less work for the optimizer to figure out what to prune).

Related issue number

N/A

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Copy link

codspeed-hq bot commented Mar 20, 2024

CodSpeed Performance Report

Merging #1238 will not alter performance

Comparing dh/input-assocs (e5c5ded) with main (d73668f)

Summary

✅ 152 untouched benchmarks

@davidhewitt davidhewitt merged commit 3d2e53e into main Mar 20, 2024
27 of 28 checks passed
@davidhewitt davidhewitt deleted the dh/input-assocs branch March 20, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant