Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace setup.py and versioneer with pyproject.toml and setuptools_scm. #616

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

hameerabbasi
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Merging #616 (4099e6f) into master (492c279) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #616      +/-   ##
==========================================
- Coverage   90.62%   90.62%   -0.01%     
==========================================
  Files          20       20              
  Lines        3563     3561       -2     
==========================================
- Hits         3229     3227       -2     
  Misses        334      334              

@hameerabbasi
Copy link
Collaborator Author

Looks like pytest-black fails to respect ignores, but only on Windows for some reason. I'll make a follow-up PR to switch to pre-commit which is how Black/Ruff should be done anyway.

@hameerabbasi hameerabbasi merged commit 6fca42b into pydata:master Jan 2, 2024
11 of 13 checks passed
@hameerabbasi hameerabbasi deleted the pyproject-toml branch January 2, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant