Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Add array representations to sparse array construction examples #606

Merged
merged 1 commit into from
Jan 6, 2024

Conversation

alugowski
Copy link
Contributor

Reran the examples in Construct Sparse Arrays with matrepr installed to show the result of each snippet.

Previously only the first example showed the result, but only as a dense array. This change illustrates the sparsity of the sparse arrays. Some examples become easier to follow, such as the last example showing a "bad" identity matrix with explicit zeros and a fill value of 1. A visualization of the array reinforces the written description.

@alugowski
Copy link
Contributor Author

The pre-commit.ci test fails with this message:

=====> .pre-commit-config.yaml is not a file

that all recent PRs appear to encounter.

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #606 (20bc176) into master (790f6d5) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #606   +/-   ##
=======================================
  Coverage   90.43%   90.43%           
=======================================
  Files          20       20           
  Lines        3564     3564           
=======================================
  Hits         3223     3223           
  Misses        341      341           

@hameerabbasi
Copy link
Collaborator

hameerabbasi commented Jan 5, 2024

@alugowski This seems to need a rebase after #616 and #617. CI is also green again.

@alugowski
Copy link
Contributor Author

@alugowski This seems to need a rebase after #616 and #617. CI is also green again.

Done!

@hameerabbasi hameerabbasi merged commit b8f2717 into pydata:master Jan 6, 2024
13 checks passed
@hameerabbasi
Copy link
Collaborator

Thanks for your contribution, @alugowski

@alugowski alugowski deleted the construction_repr branch January 6, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants