Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce pre-commit. #617

Merged
merged 11 commits into from
Jan 4, 2024
Merged

Introduce pre-commit. #617

merged 11 commits into from
Jan 4, 2024

Conversation

hameerabbasi
Copy link
Collaborator

No description provided.

@codecov Codecov
Copy link

codecov bot commented Jan 2, 2024 •
edited
Loading

Codecov Report

Merging #617 (fc0fef8) into master (6fca42b) will decrease coverage by 0.20%.
The diff coverage is 85.49%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #617      +/-   ##
==========================================
- Coverage   90.62%   90.42%   -0.20%     
==========================================
  Files          20       20              
  Lines        3561     3560       -1     
==========================================
- Hits         3227     3219       -8     
- Misses        334      341       +7

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 2, 2024
View reviewed changes
sparse/_dok.py
from ._sparse_array import SparseArray
from ._utils import equivalent

Check notice

Code scanning / CodeQL

Cyclic import

Import of module [sparse._utils](1) begins an import cycle.
sparse/_sparse_array.py

import numpy as np
import scipy.sparse as ss

from ._umath import elemwise
from ._utils import _zero_of_dtype, html_table, equivalent, normalize_axis
from ._utils import _zero_of_dtype, equivalent, html_table, normalize_axis

Check notice

Code scanning / CodeQL

Cyclic import

Import of module [sparse._utils](1) begins an import cycle.
sparse/_umath.py
from itertools import zip_longest

from ._utils import isscalar, equivalent, _zero_of_dtype
from ._utils import _zero_of_dtype, equivalent, isscalar

Check notice

Code scanning / CodeQL

Cyclic import

Import of module [sparse._utils](1) begins an import cycle.
sparse/_umath.py
from ._dok import DOK
from ._sparse_array import SparseArray

Check notice

Code scanning / CodeQL

Cyclic import

Import of module [sparse._sparse_array](1) begins an import cycle.
sparse/_coo/common.py
from numpy.core._exceptions import UFuncTypeError

from .core import COO, as_coo

Check notice

Code scanning / CodeQL

Cyclic import

Import of module [sparse._coo.core](1) begins an import cycle.
sparse/_coo/core.py
)
from .indexing import getitem

Check notice

Code scanning / CodeQL

Cyclic import

Import of module [sparse._coo.indexing](1) begins an import cycle.
sparse/tests/test_elemwise.py
import operator

import sparse

Check notice

Code scanning / CodeQL

Module is imported with 'import' and 'import from'

Module 'sparse' is imported with both 'import' and 'import from'.
sparse/_coo/common.py
from .._umath import _cartesian_product
from .core import COO

Check notice

Code scanning / CodeQL

Cyclic import

Import of module [sparse._coo.core](1) begins an import cycle.
@hameerabbasi hameerabbasi requested a review from mtsokol January 4, 2024 14:14
@hameerabbasi
Copy link
Collaborator Author

hameerabbasi commented Jan 4, 2024 •
edited
Loading

@mtsokol can we make sure that we aren't reducing the Array API coverage here? For example, I noticed any, all, min, max, sum, prod weren't tested before. Just making sure there aren't any others.

Pretty sure the docs build caught everything.

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 4, 2024
View reviewed changes
sparse/tests/test_elemwise.py
@@ -720,7 +716,7 @@
def test_no_deprecation_warning():
a = np.array([1, 2])
s = sparse.COO(a, a, shape=(3,))
s == s
assert_eq(s == s, np.broadcast_to(True, s.shape))

Check warning

Code scanning / CodeQL

Comparison of identical values

Comparison of identical values; use cmath.isnan() if testing for not-a-number.
sparse/_common.py

from ._coo.common import asCOO

Check notice

Code scanning / CodeQL

Cyclic import

Import of module [sparse._coo.common](1) begins an import cycle.
sparse/_coo/core.py
@@ -935,15 +918,21 @@
array([[ 2, 3],
[ 6, 11]], dtype=int64)
"""
from .._common import dot

Check notice

Code scanning / CodeQL

Cyclic import

Import of module [sparse._common](1) begins an import cycle.
sparse/_coo/core.py
return dot(self, other)

def __matmul__(self, other):
from .._common import matmul

Check notice

Code scanning / CodeQL

Cyclic import

Import of module [sparse._common](1) begins an import cycle.
sparse/_coo/core.py
try:
return matmul(self, other)
except NotImplementedError:
return NotImplemented

def __rmatmul__(self, other):
from .._common import matmul

Check notice

Code scanning / CodeQL

Cyclic import

Import of module [sparse._common](1) begins an import cycle.
@hameerabbasi hameerabbasi self-assigned this Jan 4, 2024
@hameerabbasi hameerabbasi removed the request for review from mtsokol January 4, 2024 14:49
@hameerabbasi hameerabbasi merged commit e1990b2 into pydata:master Jan 4, 2024
@hameerabbasi hameerabbasi deleted the pre-commit branch January 4, 2024 15:11
This was referenced Jan 5, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hameerabbasi hameerabbasi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hameerabbasi