-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add coarsen.construct #5476
Add coarsen.construct #5476
Conversation
Hello @dcherian! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2021-06-23 16:18:22 UTC |
bd9f699
to
472b50e
Compare
9f64375
to
780230d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good I left some minor comments. I have not looked at the moved tests.
Co-authored-by: Mathias Hauser <mathause@users.noreply.github.com>
…rsen_reshape * 'coarsen_reshape' of github.com:dcherian/xarray: Apply suggestions from code review
This should be ready for review & merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
* main: Improve error message for guess engine (pydata#5455) Refactor dataset groupby tests (pydata#5506) DOC: zarr note on encoding (pydata#5427) Allow plotting categorical data (pydata#5464)
Thanks for the review @mathause |
pre-commit run --all-files
whats-new.rst
api.rst
Builds on #5474
Here's an example
What do people think of this syntax:
{"time": ("year", "month"), "x": ("x", "x_reshaped")
? Should we instead do{"time": "month", "x": "x_reshaped"}
and have the user later rename thex
ortime
dimension if they want?