-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unify freq strings (independent of pd version) #8627
Conversation
… into unify_freq_strings
Co-authored-by: Spencer Clark <spencerkclark@gmail.com>
Some more updates. I think this needs more work still. But to make sure I don't forget: I don't update the following line: Line 330 in 5a92d48
There is a test with a negative frequency ( Should |
Thanks @mathause — it does seem reasonable to update our |
I am marking this ready to review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mathause—I think this looks good. Awesome that this enables us to silence all the frequency-string-related deprecation warnings in the test suite too!
I'm approving, but could you just add an additional test for both _legacy_to_new_freq
and _new_to_legacy_freq
that a pandas-only offset string gets passed through unmodified without raising an error?
Thanks a lot @mathause ! |
whats-new.rst
api.rst
Probably not ready for review yet.