Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infer_freq: return 'YE' (#8629 follow-up) #8642

Merged
merged 3 commits into from
Jan 23, 2024

Conversation

mathause
Copy link
Collaborator

I realized that the return value of infer_freq was not updated. #8627 will try to suppress all warnings in the test suite, so this is just the minimal PR.

Sorry for all the spam @spencerkclark

Copy link
Collaborator

@max-sixty max-sixty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@spencerkclark spencerkclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries—great catch @mathause—thanks!

@mathause mathause added the plan to merge Final call for comments label Jan 23, 2024
@spencerkclark spencerkclark merged commit 4bb5175 into pydata:main Jan 23, 2024
33 checks passed
@mathause mathause deleted the freq_string_fix_infer_freq branch June 6, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plan to merge Final call for comments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants