-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
book.py::_convert_content_to_stream incorrectly handling unsupported filetypes #96
Comments
NickRL21
changed the title
book.py incorrectly handling unsupported filetypes
book.py::_convert_content_to_stream incorrectly handling unsupported filetypes
Oct 12, 2020
chfw
added a commit
that referenced
this issue
Oct 12, 2020
thanks for your report. Please verify 0.6.3 and see if the behaviour has been corrected. |
Working as expected in 0.6.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After updating pyexcel-io I discovered this bug when intentionally passing an unsupported filetype in one of my unittests.
When passing the unsupported filetype into get_book the expected exception in the past would have been one of (FileTypeNotSupported, NoSupportingPluginFound, SupportingPluginAvailableButNotInstalled) however in book.py::_convert_content_to_stream (line 231) the call to manager.get_io (line 232) results in None causing the write method to be called on a NoneType (line 244) resulting in a generic attribute error.
pyexcel version info
The text was updated successfully, but these errors were encountered: