Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 96 #97

Merged
merged 5 commits into from
Oct 12, 2020
Merged

Issue 96 #97

merged 5 commits into from
Oct 12, 2020

Conversation

chfw
Copy link
Member

@chfw chfw commented Oct 12, 2020

fix #96

With your PR, here is a check list:

  • Has test cases written?
  • Has all code lines tested?
  • Has make format been run?
  • Please update CHANGELOG.yml(not CHANGELOG.rst)
  • Passes all Travis CI builds
  • Has fair amount of documentation if your change is complex
  • Agree on NEW BSD License for your contribution

@codecov-io
Copy link

codecov-io commented Oct 12, 2020

Codecov Report

Merging #97 into dev will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #97      +/-   ##
==========================================
- Coverage   97.80%   97.77%   -0.03%     
==========================================
  Files          52       52              
  Lines        3328     3331       +3     
==========================================
+ Hits         3255     3257       +2     
- Misses         73       74       +1     
Impacted Files Coverage Δ
pyexcel_io/readers/__init__.py 100.00% <ø> (ø)
pyexcel_io/reader.py 97.10% <100.00%> (-0.24%) ⬇️
pyexcel_io/readers/csvz.py 100.00% <100.00%> (ø)
tests/test_issues.py 100.00% <100.00%> (ø)
pyexcel_io/plugins.py 95.49% <0.00%> (-0.91%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b77fc81...595657b. Read the comment docs.

@chfw chfw merged commit 71c28b4 into dev Oct 12, 2020
@chfw chfw deleted the issue-96 branch October 12, 2020 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

book.py::_convert_content_to_stream incorrectly handling unsupported filetypes
2 participants