-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure package #43
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
In pyfar we have a folder for each submodule, with a init as well. In this way its easier to manage what is public, and what not, and whats part of the doc and what not. I would suggest to shift the submodules, into folders with a Init defining which method should be used and which not (e.g. private helpers).
I would not do this before agreeing on the new import structure. |
|
Any suggestions?
Yes, docs and tests need to be adjusted |
What is the idea for later having convenience functions for that, which will wrap truncation, filtering, edc computation and analysis. Would they go in an extra module? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and we need to merge dev_v1.0.0 again, since there where changes on main, which were not merged into dev
I would argue that parameters is even less descriptive than (r)oom (a)coustic (p)arameters ;) |
I'm fine with both names, rap and paramters. |
done |
Tests will be adapted as soon as the import structure is finalized.
Functions which have pyfar contour parts already will be replaced in separate PRs