Remove typing_extensions from the tests requirements #1944
Conversation
Pierre-Sassoulas
added
the
Maintenance
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1944 +/- ##
=======================================
Coverage 92.63% 92.63%
=======================================
Files 94 94
Lines 10869 10869
=======================================
Hits 10069 10069
Misses 800 800
Flags with carried forward coverage won't be shown. Click here to find out more. |
Pierre-Sassoulas
force-pushed
the
fix-typing-extensions-requirements
branch
from
2159af3 to
f6b3495
Compare
|
f6b3495 's CI should fail for python 3.10. |
for more information, see https://pre-commit.ci
It is an issue in a downstream dependency, and is currently being fixed in pylint: pylint-dev/pylint#8030 Has been fixed in Astroid in: pylint-dev/astroid#1944
It is an issue in a downstream dependency, and is currently being fixed in pylint: pylint-dev/pylint#8030 Has been fixed in Astroid in: pylint-dev/astroid#1944
It is an issue in a downstream dependency, and is currently being fixed in pylint: pylint-dev/pylint#8030 Has been fixed in Astroid in: pylint-dev/astroid#1944
| "typing-extensions>=4.0.0;python_version<'3.10'", | ||
| "typing-extensions>=4.0.0", |
There was a problem hiding this comment.
Why was this changed? From what I can see, typing-extensions are only required on python versions lower than 3.11 (because typing.Self is new in 3.11) and 3.13 or newer (because TypedDict will be removed from typing).
There was a problem hiding this comment.
Pipeline was failing for python 3.10 and 3.11 if we left it. https://github.com/PyCQA/astroid/actions/runs/3867121331/jobs/6591719348 / https://github.com/PyCQA/astroid/actions/runs/3867121331/jobs/6591719377
There was a problem hiding this comment.
Technically this is correct though. We should only need this on <3.11. However, it is easier to not have to update this and just install every time.
Are you in an environment where typing-extensions is unavailable?
There was a problem hiding this comment.
I tried to fix these issues in #1964 and tests pass for me locally without typing_extensions.
There was a problem hiding this comment.
Technically this is correct though. We should only need this on
<3.11. However, it is easier to not have to update this and just install every time.Are you in an environment where
typing-extensionsis unavailable?
I just noticed a new typing-extensions dependency that seemed to be only necessary for tests and after looking a bit into it, it seems like it's not required for tests either with a small modification.
There was a problem hiding this comment.
I'll have a look! Thanks!
It is an issue in a downstream dependency, and is currently being fixed in pylint: pylint-dev/pylint#8030 Has been fixed in Astroid in: pylint-dev/astroid#1944
It is an issue in a downstream dependency, and is currently being fixed in pylint: pylint-dev/pylint#8030 Has been fixed in Astroid in: pylint-dev/astroid#1944
Type of Changes
Description
The tests had their very own version of typing extensions which prevented us from seeing it was a run time dependencies and made the tests useless to actually see this issue. See #1942 (comment)
Closes #1945