Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove typing_extensions from the tests requirements #1944

Merged
merged 4 commits into from
Jan 8, 2023
Merged

Remove typing_extensions from the tests requirements #1944

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f6b3495
Remove typing_extensions from the tests requirements
Pierre-Sassoulas Jan 8, 2023
c43bc39
Fix the version check for 'typing-extensions' dependency
Pierre-Sassoulas Jan 8, 2023
a83b1fb
Update ChangeLog
Pierre-Sassoulas Jan 8, 2023
c6e3667
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ChangeLog
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ What's New in astroid 2.13.2?
=============================
Release date: TBA

* Removed version conditions on typing_extensions dependency. Removed typing_extensions from
our tests requirements as it was preventing issues to appear in our continuous integration.

Closes #1945


What's New in astroid 2.13.1?
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ dependencies = [
"wrapt>=1.14,<2;python_version>='3.11'",
"wrapt>=1.11,<2;python_version<'3.11'",
"typed-ast>=1.4.0,<2.0;implementation_name=='cpython' and python_version<'3.8'",
"typing-extensions>=4.0.0;python_version<'3.10'",
"typing-extensions>=4.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this changed? From what I can see, typing-extensions are only required on python versions lower than 3.11 (because typing.Self is new in 3.11) and 3.13 or newer (because TypedDict will be removed from typing).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pipeline was failing for python 3.10 and 3.11 if we left it. https://github.com/PyCQA/astroid/actions/runs/3867121331/jobs/6591719348 / https://github.com/PyCQA/astroid/actions/runs/3867121331/jobs/6591719377

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically this is correct though. We should only need this on <3.11. However, it is easier to not have to update this and just install every time.

Are you in an environment where typing-extensions is unavailable?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to fix these issues in #1964 and tests pass for me locally without typing_extensions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically this is correct though. We should only need this on <3.11. However, it is easier to not have to update this and just install every time.

Are you in an environment where typing-extensions is unavailable?

I just noticed a new typing-extensions dependency that seemed to be only necessary for tests and after looking a bit into it, it seems like it's not required for tests either with a small modification.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have a look! Thanks!

]
dynamic = ["version"]

Expand Down
1 change: 0 additions & 1 deletion requirements_test_min.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
coverage~=7.0
pytest
pytest-cov~=4.0
typing-extensions>=4.0.0