Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle objects.Super in helpers.object_type() #2177

Merged
merged 1 commit into from
May 14, 2023

Conversation

jacobtylerwalls
Copy link
Member

Type of Changes

Type
🐛 Bug fix

Description

Refs pylint-dev/pylint#8554 (to be closed with a separate regression test)

@codecov
Copy link

codecov bot commented May 13, 2023

Codecov Report

Merging #2177 (a2cb375) into main (e1b577a) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2177   +/-   ##
=======================================
  Coverage   92.60%   92.60%           
=======================================
  Files          94       94           
  Lines       10800    10800           
=======================================
  Hits        10001    10001           
  Misses        799      799           
Flag Coverage Δ
linux 92.36% <100.00%> (ø)
pypy 87.53% <100.00%> (ø)
windows 92.19% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
astroid/helpers.py 94.30% <100.00%> (ø)

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !

@Pierre-Sassoulas Pierre-Sassoulas merged commit b186f68 into pylint-dev:main May 14, 2023
github-actions bot pushed a commit that referenced this pull request May 14, 2023
@jacobtylerwalls jacobtylerwalls deleted the super-crash branch May 14, 2023 16:52
@Pierre-Sassoulas Pierre-Sassoulas added backported Assigned once the backport is done and removed backport maintenance/2.15.x labels Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported Assigned once the backport is done Crash 💥
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants