Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add regression test for #8554 #8682

Merged
merged 5 commits into from
Jun 7, 2023
Merged

Add regression test for #8554 #8682

merged 5 commits into from
Jun 7, 2023

Conversation

jacobtylerwalls
Copy link
Member

Type of Changes

Type
✓ 🐛 Bug fix

Description

Closes #8554

Depends on pylint-dev/astroid#2177

@jacobtylerwalls jacobtylerwalls added Needs astroid update Needs an astroid update (probably a release too) before being mergable backport maintenance/3.3.x labels May 13, 2023
@jacobtylerwalls jacobtylerwalls added this to the 2.17.5 milestone May 13, 2023
@Pierre-Sassoulas
Copy link
Member

This one is going to be technical, here we need astroid 3.0.0a3 but the backport will need 2.15.5.

@Pierre-Sassoulas Pierre-Sassoulas added Needs backport Needs to be cherry-picked on the current patch version by a pylint's maintainer Maintenance Discussion or action around maintaining pylint or the dev workflow and removed backport maintenance/3.3.x Needs backport Needs to be cherry-picked on the current patch version by a pylint's maintainer labels May 14, 2023
@Pierre-Sassoulas Pierre-Sassoulas mentioned this pull request May 14, 2023
Merged
@Pierre-Sassoulas
Copy link
Member

Upgrading astroid in #8685 because updating the version is not the only thing to do.

@Pierre-Sassoulas
Copy link
Member

(So we can backport)

@jacobtylerwalls jacobtylerwalls removed the Needs astroid update Needs an astroid update (probably a release too) before being mergable label Jun 7, 2023
@Pierre-Sassoulas Pierre-Sassoulas enabled auto-merge (squash) June 7, 2023 10:25
@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Merging #8682 (625ca73) into main (a67ffbd) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8682   +/-   ##
=======================================
  Coverage   95.82%   95.82%           
=======================================
  Files         173      173           
  Lines       18386    18386           
=======================================
  Hits        17618    17618           
  Misses        768      768

@Pierre-Sassoulas Pierre-Sassoulas merged commit 2acca90 into pylint-dev:main Jun 7, 2023
@github-actions github-actions bot mentioned this pull request Jun 7, 2023
Merged
github-actions bot pushed a commit that referenced this pull request Jun 7, 2023
@jacobtylerwalls @github-actions
Add regression test for #8554 (#8682)
e3dce2f 
Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
(cherry picked from commit 2acca90)
@jacobtylerwalls jacobtylerwalls deleted the super-crash branch June 7, 2023 10:40
Pierre-Sassoulas pushed a commit that referenced this pull request Jun 7, 2023
@github-actions @jacobtylerwalls
Add regression test for #8554 (#8682) (#8751)
b59dfea 
Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
(cherry picked from commit 2acca90)

Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Backported Maintenance Discussion or action around maintaining pylint or the dev workflow
Projects
None yet
Milestone
2.17.5
Development

Successfully merging this pull request may close these issues.

Crash using isinstance + super due to Astroid
2 participants
@jacobtylerwalls @Pierre-Sassoulas