Limit inference to a maximum of 100 results at a time #586
Conversation
brycepg
force-pushed
the
issue-579
branch
2 times, most recently
from
11372ca
to
ea67cd8
Compare
astroid/util.py
Outdated
|
|
||
| import importlib | ||
| import lazy_object_proxy | ||
|
|
||
| MAX_INFERABLE = int(os.environ.get("ASTROID_MAX_INFERABLE", 100)) |
There was a problem hiding this comment.
We usually set this in the Manager class, so let's move it there. Also currently it's a bit of a mess, as the options are assigned to the Manager instance directly, but that should be a separate improvement.
astroid/util.py
Outdated
| exponentially exploding possible results. | ||
| """ | ||
| count = 0 | ||
| for result in iterable: |
There was a problem hiding this comment.
Can also be something like this:
from itertools import islice
def limit_inference(iterable, size):
yield from islice(iterable, size)
has_more = next(iterable, False)
if has_more is not False:
yield Uninferable
return
There was a problem hiding this comment.
Nice, looks a lot better
spot performance issues. Add new envrionment variable call ASTROID_MAX_INFERABLE to tune the max inferable amount of values at a time. Close pylint-dev#579 Close pylint-dev/pylint#2251
|
Nice! Is there a rough timeline for a pylint release containing this fix? We are actually suffering a bit from pylint's runtime in our project, so any improvement would be highly welcome. We use |
|
Hey @brycepg did you see my comment regarding |
|
@svenpanne We'll release 2.0 next week. I actually don't know how to do that in |
| @@ -52,6 +52,8 @@ def __init__(self): | |||
| # Export these APIs for convenience | |||
| self.register_transform = self._transform.register_transform | |||
| self.unregister_transform = self._transform.unregister_transform | |||
| self.max_inferable = int( | |||
There was a problem hiding this comment.
Let's default it to 100 by default here, if someone wants to control the value, it should set it against the Manager itself.
|
@PCManticore ok i'll change it |
Prevents spot performance issues.
Add new envrionment variable call ASTROID_MAX_INFERABLE to tune
the max inferable amount of values at a time.
Close #579
Close pylint-dev/pylint#2251