Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abnormal test running time for consider-using-join test file #2251

Closed
PCManticore opened this issue Jul 4, 2018 · 3 comments
Closed

Abnormal test running time for consider-using-join test file #2251

PCManticore opened this issue Jul 4, 2018 · 3 comments

Comments

@PCManticore
Copy link
Contributor

Steps to reproduce

  1. run pytest pylint -k consider_join
  2. Watch how the test runs for a couple of seconds

Current behavior

The given test triggers abnormal performance behaviour for a particular check (doesn't seem to be consider-using-join as I disabled that one and it was still taking too many seconds to complete)

Expected behavior

For the test to complete faster than that.

pylint --version output

master

@brycepg
Copy link
Contributor

brycepg commented Jul 6, 2018

reusing the name result is causing a 20000 possible inference values, similar to pylint-dev/astroid#579. I've reduced test time from 16s to 2.26s by limiting possible results to 100

brycepg added a commit to brycepg/astroid that referenced this issue Jul 6, 2018
spot performance issues.

Add new envrionment variable call ASTROID_MAX_INFERABLE to tune
the max inferable amount of values at a time.

Close pylint-dev#579
Close pylint-dev/pylint#2251
brycepg added a commit to brycepg/astroid that referenced this issue Jul 6, 2018
spot performance issues.

Add new envrionment variable call ASTROID_MAX_INFERABLE to tune
the max inferable amount of values at a time.

Close pylint-dev#579
Close pylint-dev/pylint#2251
brycepg added a commit to brycepg/astroid that referenced this issue Jul 6, 2018
spot performance issues.

Add new envrionment variable call ASTROID_MAX_INFERABLE to tune
the max inferable amount of values at a time.

Close pylint-dev#579
Close pylint-dev/pylint#2251
brycepg added a commit to brycepg/astroid that referenced this issue Jul 6, 2018
spot performance issues.

Add new envrionment variable call ASTROID_MAX_INFERABLE to tune
the max inferable amount of values at a time.

Close pylint-dev#579
Close pylint-dev/pylint#2251
@PCManticore
Copy link
Contributor Author

Thanks @sushobhit27 and @brycepg That's a crazy performance improvement! Nice! Looking forward to see how it's going to affect other topic-performance issues.

brycepg added a commit to brycepg/astroid that referenced this issue Jul 6, 2018
spot performance issues.

Add new envrionment variable call ASTROID_MAX_INFERABLE to tune
the max inferable amount of values at a time.

Close pylint-dev#579
Close pylint-dev/pylint#2251
brycepg added a commit to brycepg/astroid that referenced this issue Jul 6, 2018
spot performance issues.

Add new envrionment variable call ASTROID_MAX_INFERABLE to tune
the max inferable amount of values at a time.

Close pylint-dev#579
Close pylint-dev/pylint#2251
brycepg added a commit to pylint-dev/astroid that referenced this issue Jul 6, 2018
spot performance issues.

Add new envrionment variable call ASTROID_MAX_INFERABLE to tune
the max inferable amount of values at a time.

Close #579
Close pylint-dev/pylint#2251
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants