Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows Artifacts have incorrect Slugification #25

Merged
merged 2 commits into from
Nov 11, 2023
Merged

Windows Artifacts have incorrect Slugification #25

merged 2 commits into from
Nov 11, 2023

Conversation

stdedos
Copy link
Collaborator

@stdedos stdedos commented Nov 11, 2023

@codecov Codecov
Copy link

codecov bot commented Nov 11, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e29fe48) 92.25% compared to head (d11811e) 92.16%.

❗ Current head d11811e differs from pull request most recent head a4245b1. Consider uploading reports for the commit a4245b1 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
- Coverage   92.25%   92.16%   -0.09%     
==========================================
  Files          18       18              
  Lines         542      536       -6     
  Branches      104      104              
==========================================
- Hits          500      494       -6     
  Misses         29       29              
  Partials       13       13
Flag Coverage Δ
3.10 91.97% <ø> (-0.09%) ⬇️
3.11 91.97% <ø> (-0.09%) ⬇️
3.6 91.97% <ø> (-0.09%) ⬇️
3.7 91.97% <ø> (?)
3.8 91.97% <ø> (?)
3.9 91.97% <ø> (?)
macos-latest 91.97% <ø> (?)
ubuntu-20.04 91.97% <ø> (-0.09%) ⬇️
ubuntu-latest 91.97% <ø> (-0.09%) ⬇️
windows-latest 91.97% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stdedos stdedos force-pushed the ci/fix-windows-artifacts-slugification branch 2 times, most recently from dc7d24c to b1d6d99 Compare November 11, 2023 21:18
@stdedos stdedos force-pushed the ci/fix-windows-artifacts-slugification branch from b1d6d99 to d11811e Compare November 11, 2023 21:26
@stdedos
Copy link
Collaborator Author

stdedos commented Nov 11, 2023

Seems to be prettier now: https://github.com/pylint-dev/pylint-pytest/actions/runs/6836642685/job/18591789586?pr=25#step:3:6

@stdedos stdedos added bug Something isn't working CI labels Nov 11, 2023
@stdedos stdedos self-assigned this Nov 11, 2023
@stdedos stdedos added this to the Release v1.1.x milestone Nov 11, 2023
@stdedos stdedos merged commit 3cee43d into pylint-dev:master Nov 11, 2023
17 checks passed
@stdedos stdedos mentioned this pull request Nov 11, 2023
Merged
stdedos added a commit that referenced this pull request Nov 13, 2023
@stdedos
Release v1.1.5
c84ad36 
* removes more false positives for unused-argument (#21)
* A collection of minor improvements to tests (#26)
* Windows Artifacts have incorrect Slugification (#25)

Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees

@stdedos stdedos

Labels
bug Something isn't working CI
Projects
None yet
Milestone
Release v1.1.x
Development

Successfully merging this pull request may close these issues.
2 participants
@stdedos @Pierre-Sassoulas