A collection of minor improvements to tests #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Non-`--cov` invocation is unaffected; "no reason" not to generate `--cov-report=html` in an untracked directory AFAIS. Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
Would've been better to get the path via `requests.config.rootdir`, but it looks like a pain to inject the `requests` fixture here. Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #26 +/- ##
==========================================
+ Coverage 92.16% 92.25% +0.08%
==========================================
Files 18 18
Lines 536 542 +6
Branches 104 104
==========================================
+ Hits 494 500 +6
Misses 29 29
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Pierre-Sassoulas
approved these changes
Nov 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
--cov-report=htmltoaddoptsNon-
--covinvocation is unaffected;"no reason" not to generate
--cov-report=htmlin an untracked directory AFAIS.Fix tests running via PyCharm
Would've been better to get the path via
requests.config.rootdir,but it looks like a pain to inject the
requestsfixture here.Improve copy-paste docstring from 8756cc4