Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

define dev dependencies in the requirement file only #39

Merged
merged 3 commits into from
Jan 30, 2024
Merged

define dev dependencies in the requirement file only #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fb39a85
define dev dependencies in the requirement file only
anis-campos Jan 29, 2024
000a314
Leave a deprecation note for the future readers
stdedos Jan 30, 2024
a902b18
Remove `pyproject.toml` references from the development extra depende…
stdedos Jan 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,12 @@ export PYTHONPATH=.
pip install --quiet --upgrade 'pip==23.3.1' 'pip-tools==7.3'

# generates a lock file with pinned version of all dependencies to be used by the CI and local devs
requirements/dev.txt: .venv requirements/dev.in pyproject.toml
requirements/dev.txt: .venv requirements/dev.in
pip-compile \
--quiet --generate-hashes --max-rounds=20 --strip-extras \
--resolver=backtracking \
--output-file requirements/dev.txt \
requirements/dev.in pyproject.toml
requirements/dev.in

# upgrades the dependencies to their latest/matching version
.PHONY: upgrade
Expand All @@ -26,7 +26,7 @@ upgrade: .venv
--upgrade \
--resolver=backtracking \
--output-file requirements/dev.txt \
requirements/dev.in pyproject.toml
requirements/dev.in


# creates the venv if not present then install the dependencies, the package and pre-commit
Expand Down
8 changes: 1 addition & 7 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,13 +45,7 @@ dependencies = [
"pytest>=4.6",
]

[project.optional-dependencies]
test = [
"pytest",
"pytest-cov",
# For linting purposes, only pylint>3 is supported
"pylint>=3",
]
# [project.optional-dependencies] moved to requirements/dev.in

[project.urls]
Changelog = "https://github.com/pylint-dev/pylint-pytest/blob/master/CHANGELOG.md"
Expand Down
3 changes: 3 additions & 0 deletions requirements/dev.in
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# For linting purposes, only pylint>3 is supported
pylint>=3

# to handle dependencies
pip-tools
wheel
Expand Down
5 changes: 2 additions & 3 deletions requirements/dev.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# This file is autogenerated by pip-compile with Python 3.11
# by the following command:
#
# pip-compile --generate-hashes --max-rounds=20 --output-file=requirements/dev.txt --strip-extras pyproject.toml requirements/dev.in
# pip-compile --generate-hashes --max-rounds=20 --output-file=requirements/dev.txt --strip-extras requirements/dev.in
#
astroid==3.0.1 \
--hash=sha256:7d5895c9825e18079c5aeac0572bc2e4c83205c95d416e0b4fee8bc361d2d9ca \
Expand Down Expand Up @@ -135,7 +135,7 @@ pre-commit==3.5.0 \
pylint==3.0.2 \
--hash=sha256:0d4c286ef6d2f66c8bfb527a7f8a629009e42c99707dec821a03e1b51a4c1496 \
--hash=sha256:60ed5f3a9ff8b61839ff0348b3624ceeb9e6c2a92c514d81c9cc273da3b6bcda
# via pylint-pytest (pyproject.toml)
# via -r requirements/dev.in
pyproject-hooks==1.0.0 \
--hash=sha256:283c11acd6b928d2f6a7c73fa0d01cb2bdc5f07c57a2eeb6e83d5e56b97976f8 \
--hash=sha256:f271b298b97f5955d53fb12b72c1fb1948c22c1a6b70b315c54cedaca0264ef5
Expand All @@ -145,7 +145,6 @@ pytest==7.4.3 \
--hash=sha256:d989d136982de4e3b29dabcc838ad581c64e8ed52c11fbe86ddebd9da0818cd5
# via
# -r requirements/dev.in
# pylint-pytest (pyproject.toml)
# pytest-cov
pytest-cov==4.1.0 \
--hash=sha256:3904b13dfbfec47f003b8e77fd5b589cd11904a21ddf1ab38a64f204d6a10ef6 \
Expand Down