define dev dependencies in the requirement file only #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we can mix pyproject.toml and dependency files, as the first one will be used while installing the package but the last one only serve in the CI. Keeping the dev requirement in one place will simplify the requirement management
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #39 +/- ##
=======================================
Coverage 98.02% 98.02%
=======================================
Files 20 20
Lines 556 556
Branches 105 105
=======================================
Hits 545 545
Misses 8 8
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
…ncies Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
stdedos
approved these changes
Jan 30, 2024
stdedos
added a commit
that referenced
this pull request
Feb 2, 2024
# Added * Migrate setup.py to pyproject.toml (#8) * Support for Python 3.12 (#3, "side effect" of #8) * Introduced @dependabot (part of #28) * Improved reliability of the `FixtureChecker` class (#29) # Removed * Support for Python 3.6 & 3.7 (#23) # Improved * Increased reproducibility of the project, by using `pip-compile` for the development dependencies (#28, small bugfix in #39) * Minor CI + License updates (in 29f0c33, e0e529a, 8f56d1c) Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
stdedos
added a commit
that referenced
this pull request
Feb 2, 2024
# Added * Increased reproducibility of the project, by using `pip-compile` for the development dependencies (#28, small bugfix in #39) * Introduced @dependabot (part of #28) # Removed * Support for Python 3.6 & 3.7 (#23) # Improved * Migrate setup.py to pyproject.toml (#8) * Support for Python 3.12 (#3, "side effect" of #8) * Improved reliability of the `FixtureChecker` class (#29) * Minor CI + License updates (in 29f0c33, e0e529a, 8f56d1c) Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
stdedos
added a commit
that referenced
this pull request
Feb 2, 2024
# Added * Increased reproducibility of the project, by using `pip-compile` for the development dependencies (#28, small bugfix in #39) * Introduced @dependabot (part of #28) # Removed * Support for Python 3.6 & 3.7 (#23) # Improved * Migrate setup.py to pyproject.toml (#8) * Support for Python 3.12 (#3, "side effect" of #8) * Improved reliability of the `FixtureChecker` class (#29) * Minor CI + License updates (in 29f0c33, e0e529a, 8f56d1c) Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we can mix pyproject.toml and dependency files, as the first one will be used while installing the package but the last one only serve in the CI.
Keeping the dev requirement in one place will simplify the requirement management