-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rework dev dependencies management #28
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #28 +/- ##
=======================================
Coverage 93.98% 93.98%
=======================================
Files 18 18
Lines 549 549
Branches 106 106
=======================================
Hits 516 516
Misses 23 23
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
494d531
to
7b5fec0
Compare
🤔 , might be wise to pick some stuffs from #8, like dropping the |
I apologize, there were a couple of issues with You'll probably need to update your base |
b8826ff
to
2462e0f
Compare
After a long wait, #8 was merged! 🎉 🎉 🎉 🎉 🎉 |
Perfect, so let's rebase this one then. |
2462e0f
to
952f4e4
Compare
this rework allows for a better dev dependency management. now a simple `make install` shall provid the required dev environment for both CI and local dev. using a dev-requirement.txt files ensures repeatability and consistency between CI runs and local dev.
952f4e4
to
fa7834b
Compare
f26a98d
to
188b53f
Compare
188b53f
to
cbae715
Compare
cbae715
to
26e735a
Compare
Okay, so - since the actions are passing, and you think this is a step forward - fine by me. Can it now be updated easily, however? Can something pick this up? (Dependabot, Renovate, etc) |
Not sur for the others, but Dependabot is very efficient in bumping packages in the requirement.txt files with |
Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good, thank you! Let's see how this works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good, thank you! Let's see how this works.
# Added * Migrate setup.py to pyproject.toml (#8) * Support for Python 3.12 (#3, "side effect" of #8) * Introduced @dependabot (part of #28) * Improved reliability of the `FixtureChecker` class (#29) # Removed * Support for Python 3.6 & 3.7 (#23) # Improved * Increased reproducibility of the project, by using `pip-compile` for the development dependencies (#28, small bugfix in #39) * Minor CI + License updates (in 29f0c33, e0e529a, 8f56d1c) Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
# Added * Increased reproducibility of the project, by using `pip-compile` for the development dependencies (#28, small bugfix in #39) * Introduced @dependabot (part of #28) # Removed * Support for Python 3.6 & 3.7 (#23) # Improved * Migrate setup.py to pyproject.toml (#8) * Support for Python 3.12 (#3, "side effect" of #8) * Improved reliability of the `FixtureChecker` class (#29) * Minor CI + License updates (in 29f0c33, e0e529a, 8f56d1c) Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
# Added * Increased reproducibility of the project, by using `pip-compile` for the development dependencies (#28, small bugfix in #39) * Introduced @dependabot (part of #28) # Removed * Support for Python 3.6 & 3.7 (#23) # Improved * Migrate setup.py to pyproject.toml (#8) * Support for Python 3.12 (#3, "side effect" of #8) * Improved reliability of the `FixtureChecker` class (#29) * Minor CI + License updates (in 29f0c33, e0e529a, 8f56d1c) Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
this rework allows for a better dev dependency management.
now a simple
make install
shall provid the required dev environment for both CI and local dev.using a dev-requirement.txt files ensures repeatability and consistency between CI runs and local dev.