Migrate setup.py to pyproject.toml #8

Pierre-Sassoulas · 2023-10-14T13:01:25Z

Additionally, fixes #3

codecov · 2023-10-14T13:01:37Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (69ad82f) 93.97% compared to head (5c6d3fb) 93.98%.

❗ Current head 5c6d3fb differs from pull request most recent head 2df48d8. Consider uploading reports for the commit 2df48d8 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
+ Coverage   93.97%   93.98%   +0.01%     
==========================================
  Files          18       18              
  Lines         548      549       +1     
  Branches      106      106              
==========================================
+ Hits          515      516       +1     
  Misses         23       23              
  Partials       10       10

Flag	Coverage Δ
3.10	`93.98% <100.00%> (+0.01%)`	⬆️
3.11	`93.98% <100.00%> (+0.01%)`	⬆️
3.12	`93.98% <100.00%> (?)`
3.8	`93.98% <100.00%> (+0.01%)`	⬆️
3.9	`93.98% <100.00%> (+0.01%)`	⬆️
macos-latest	`93.98% <100.00%> (+0.01%)`	⬆️
ubuntu-latest	`93.98% <100.00%> (+0.01%)`	⬆️
windows-latest	`93.98% <100.00%> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

stdedos · 2023-10-14T13:41:37Z

Let's do a direct-to-pyproject conversion instead, after we release the last pylint<3 fixes.

WDYT?

If the current setup will do us "one last release", let it be.

I guess I should also be the first name / contact person (with everything redirecting here).

Pierre-Sassoulas

I defered changing the actual content of the metadata to another PR because it's hard enough to review as is 😄 But yeah it should be changed (at least the version)

Pierre-Sassoulas · 2023-10-14T18:01:11Z

Maybe let's release a last version using setup.py first, it's going to be easier to do that if we drop support for python 3.6 first (Also 3.7 is EOL too).

stdedos · 2023-10-15T07:50:44Z

If py3.6 makes it hard for us to move forward, let's do it.

However, "are there people still depending on it"? 😕
Ubuntu 18.04 LTS shipped with py3.6 (ofc, that is now EOL too - but just saying)

Is there ... some kind of dashboard that would show us downloads/month per python version?

Pierre-Sassoulas · 2023-10-15T08:44:24Z

https://pypistats.org/packages/pylint-pytest

Seems pretty fine to do.

stdedos · 2023-10-15T08:54:00Z

Noice graphs

Yea, let's do it. But maybe after merging "outstanding issues".

Should we also release a minor after the CI-scaffolding finishes?

stdedos · 2023-10-15T08:58:09Z

btw, any idea what Null is?

They are a "significant force", but given that the 3.6 is max 58 downloads/day (very graciously 1800/mo) - it is a decision I have made already.

stdedos · 2023-10-15T08:59:18Z

And also yea - let's drop 3.7 too

There are some higher spikes - but "all in all", they are at the same level

Activating 3.8 only makes them disappear

Pierre-Sassoulas · 2023-10-15T09:00:21Z

I think we could release alphas to test the release workflow right now, release the last python 3.6 compatible version, then get on the pylint 3.0 compat, and release a new version not compatible with python 3.6 / 3.7 (everything with linter is just nice to have for long term maintenance).

Pierre-Sassoulas · 2023-10-15T09:03:34Z

WdYT ?

create 1.1.3a0 tag to test release workflow
Release 1.1.3 when the release workflow works
Drop python 3.6, (3.7 ?)
Merge Migrate setup.py to pyproject.toml #8
python 3.12 support Fix Python3.12 compatibility #3
pylint 3.0 compat
Release 1.2.0

#8 (comment)

.github/workflows/run-tests.yaml

stdedos · 2023-10-15T09:20:29Z

I was thinking:

https://github.com/pylint-dev/pylint-pytest/milestone/1

Before any release, I should be marked as the maintainer of the package: Upgrade the changelog for 1.1.3a0 release #10
Create 1.1.3a0 tag to test release workflow (whenever you want: Now, later, after CI things ... whatever is a or b I don't mind that much at this point): Upgrade the changelog for 1.1.3a0 release #10
Release 1.1.3 when the release workflow works - maybe let's finish bootstrapping the CI. We can do it whenever (i.e.: Not all linters need to be up and running)
Merge current PRs:
- fix is pytest fixture #2,
- 🐛 Ignore collection failures in non-tests PyCQA/pylint-pytest#1 (🐛 Ignore collection failures in non-tests #15),
- maybe even us manually replay removes more false positives for unused-argument PyCQA/pylint-pytest#3 (it has tests - "should be fine"),
- whoever else jumps in with a CI-accepting PR and tests.
Release 1.1.xs (if we have CI-releases, we can do it per-MR-merged - I don't mind)

https://github.com/pylint-dev/pylint-pytest/milestone/2

Drop python 3.6 + 3.7 Drop Python 3.6 + 3.7 #11
Fully migrate to pyproject.toml Migrate setup.py to pyproject.toml #8
Python 3.12 support Fix Python3.12 compatibility #3
pylint 3.0 compat Support pylint v3 #12
Release 2.0.0

Pierre-Sassoulas · 2023-10-15T09:24:15Z

Step 1/2 in #10

#8 (comment)

stdedos · 2023-10-15T10:05:31Z

Probably #13 touches here

pyproject.toml

See https://stackoverflow.com/a/58826468/2519059

#8 (comment)

# By Stavros Ntentos (14) and others # Via GitHub (10) and Stavros Ntentos (1) * master: Update/Prepare Changelog for v1.1.7 use pylint v3 in the repo remove support of pylint v1 Support pylint v3 Release v1.1.6 Minor `.github/ISSUE_TEMPLATE/bug_report.md` improvement Release v1.1.5 Improve copy-paste docstring from 8756cc4 Fix tests running via PyCharm Move `--cov-report=html` to `addopts` Windows Artifacts have incorrect Slugification Release v1.1.4 Extend coverage for `if node.name in FixtureChecker._pytest_fixtures[fixname][0].argnames:` Make `nsp/nate/better-unused-argument` merge-able with `origin/master` Improve `F6401`:`cannot-enumerate-pytest-fixtures`: 🐛 Ignore collection failures in non-tests removes more false positives for unused-argument Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com> # Conflicts: # .github/workflows/run-tests.yaml # CHANGELOG.md # setup.py # tests/base_tester.py # tox.ini Additionally, some minor format modifications at `CHANGELOG.md`

This reverts commit b8ce4ad. Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>

* Move everything from the setup.cfg to pyproject.toml * Drop python 3.6 and 3.7 #8 (comment) * Upgrade python version to python 3.8 in tooling configuration Co-authored-by: Irtaza Akram <irtaza.akram@arbisoft.com> --------- Co-authored-by: Irtaza Akram <irtaza.akram@arbisoft.com> Co-authored-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>

Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>

# By Pierre Sassoulas (3) and Stavros Ntentos (1) * master: Release v1.1.7 Upgrade python version to python 3.8 in tooling configuration Drop python 3.6 and 3.7 Move everything from the setup.cfg to pyproject.toml Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>

setup.py

for more information, see https://pre-commit.ci

Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>

Pierre-Sassoulas · 2023-12-04T09:24:00Z

Seems like there's #24 mixed in ? We can close #24 then ?

stdedos · 2023-12-19T14:51:07Z

Seems like there's #24 mixed in ? We can close #24 then ?

It seems so 😅 Looking back at the commit, I don't really get what fixed it.

The error was highly-esoteric:

  _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
  
  self = <astroid.rebuilder.TreeRebuilder object at 0x7f84bc5d7a70>
  node = <ast.TypeAlias object at 0x7f84bb2ee910>
  parent = <Module.typing l.0 at 0x7f84bc5d5e20>
  
      def visit(self, node: ast.AST | None, parent: NodeNG) -> NodeNG | None:
          if node is None:
              return None
          cls = node.__class__
          if cls in self._visit_meths:
              visit_method = self._visit_meths[cls]
          else:
              cls_name = cls.__name__
              visit_name = "visit_" + REDIRECT.get(cls_name, cls_name).lower()
  >           visit_method = getattr(self, visit_name)
  E           AttributeError: 'TreeRebuilder' object has no attribute 'visit_typealias'

(https://github.com/pylint-dev/pylint-pytest/actions/runs/6508313960/job/17677430135?pr=1#step:5:1587, for only a couple of tests: https://github.com/pylint-dev/pylint-pytest/actions/runs/6508313960/job/17677430135?pr=1#step:5:117)

But the Actions are unambiguous: It's fixed:

https://github.com/pylint-dev/pylint-pytest/actions/runs/6754228827/job/18361511074#step:6:165

Pierre-Sassoulas · 2023-12-19T14:53:05Z

AttributeError: 'TreeRebuilder' object has no attribute 'visit_typealias'

Astroid was upgraded to be able to handle a new construct from python 3.12

Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>

stdedos

🎉 🎉 🎉 🎉 🎉

Pierre-Sassoulas · 2023-12-19T15:57:32Z

Great 🎉 !!

# Added * Migrate setup.py to pyproject.toml (#8) * Support for Python 3.12 (#3, "side effect" of #8) * Introduced @dependabot (part of #28) * Improved reliability of the `FixtureChecker` class (#29) # Removed * Support for Python 3.6 & 3.7 (#23) # Improved * Increased reproducibility of the project, by using `pip-compile` for the development dependencies (#28, small bugfix in #39) * Minor CI + License updates (in 29f0c33, e0e529a, 8f56d1c) Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>

# Added * Increased reproducibility of the project, by using `pip-compile` for the development dependencies (#28, small bugfix in #39) * Introduced @dependabot (part of #28) # Removed * Support for Python 3.6 & 3.7 (#23) # Improved * Migrate setup.py to pyproject.toml (#8) * Support for Python 3.12 (#3, "side effect" of #8) * Improved reliability of the `FixtureChecker` class (#29) * Minor CI + License updates (in 29f0c33, e0e529a, 8f56d1c) Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>

Pierre-Sassoulas added the enhancement New feature or request label Oct 14, 2023

Pierre-Sassoulas force-pushed the migrate-to-setup.cfg branch from ccd301e to fdb4b77 Compare October 14, 2023 15:05

Pierre-Sassoulas changed the title ~~Migrate setup.py to setup.cfg~~ Migrate setup.py to setup.cfg / pyproject.toml Oct 14, 2023

Pierre-Sassoulas commented Oct 14, 2023

View reviewed changes

Pierre-Sassoulas marked this pull request as draft October 14, 2023 18:01

Pierre-Sassoulas added a commit that referenced this pull request Oct 15, 2023

Drop python 3.6 and 3.7

df9a991

#8 (comment)

Pierre-Sassoulas force-pushed the migrate-to-setup.cfg branch from 28f4be8 to df9a991 Compare October 15, 2023 09:10

Pierre-Sassoulas added a commit that referenced this pull request Oct 15, 2023

Drop python 3.6 and 3.7

b80fe43

#8 (comment)

Pierre-Sassoulas force-pushed the migrate-to-setup.cfg branch from df9a991 to b80fe43 Compare October 15, 2023 09:10

stdedos reviewed Oct 15, 2023

View reviewed changes

.github/workflows/run-tests.yaml Outdated Show resolved Hide resolved

stdedos added this to the Release 1.1.x milestone Oct 15, 2023

Pierre-Sassoulas mentioned this pull request Oct 15, 2023

Upgrade the changelog for 1.1.3a0 release #10

Merged

Pierre-Sassoulas added a commit that referenced this pull request Oct 15, 2023

Drop python 3.6 and 3.7

a00eb33

#8 (comment)

Pierre-Sassoulas force-pushed the migrate-to-setup.cfg branch from 4f06921 to 71848d7 Compare October 15, 2023 09:56

Pierre-Sassoulas commented Oct 15, 2023

View reviewed changes

pyproject.toml Outdated Show resolved Hide resolved

stdedos changed the title ~~Migrate setup.py to setup.cfg / pyproject.toml~~ Migrate setup.py to pyproject.toml Oct 15, 2023

Pierre-Sassoulas marked this pull request as ready for review October 17, 2023 13:27

[pyproject.toml] Migrate from test_requires to optional extra 'test'

3cbbfc6

See https://stackoverflow.com/a/58826468/2519059

Pierre-Sassoulas force-pushed the migrate-to-setup.cfg branch from ea0571c to 3cbbfc6 Compare November 4, 2023 12:14

Pierre-Sassoulas added a commit that referenced this pull request Nov 27, 2023

Drop python 3.6 and 3.7

bb6dfc8

#8 (comment)

stdedos added 2 commits December 3, 2023 21:36

Revert "Roll back from __future__ import annotations for Python 3.6"

37aea8b

This reverts commit b8ce4ad. Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>

anis-campos mentioned this pull request Dec 3, 2023

rework dev dependencies management #28

Merged

Copy-paste those changes from a different branch

05e6359

Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>

stdedos force-pushed the migrate-to-setup.cfg branch from cbdc008 to 05e6359 Compare December 4, 2023 07:12

stdedos force-pushed the master branch from 57a868b to 2280620 Compare December 4, 2023 07:24

stdedos removed the blocked label Dec 4, 2023

Merge branch 'master' into migrate-to-setup.cfg

632989a

Pierre-Sassoulas commented Dec 4, 2023

View reviewed changes

setup.py Outdated Show resolved Hide resolved

Pierre-Sassoulas requested a review from stdedos December 4, 2023 08:25

Pierre-Sassoulas and others added 3 commits December 4, 2023 09:46

Update setup.py

de51223

[pre-commit.ci] auto fixes from pre-commit.com hooks

975e1e7

for more information, see https://pre-commit.ci

chmod -x setup.py

5c6d3fb

Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>

stdedos mentioned this pull request Dec 19, 2023

Add python 3.12 support in CI and metadata #24

Closed

Correct CHANGELOG.md

2df48d8

Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>

stdedos approved these changes Dec 19, 2023

View reviewed changes

stdedos merged commit f559398 into master Dec 19, 2023
33 checks passed

Pierre-Sassoulas deleted the migrate-to-setup.cfg branch December 19, 2023 15:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate setup.py to pyproject.toml #8

Migrate setup.py to pyproject.toml #8

Pierre-Sassoulas commented Oct 14, 2023 •

edited by stdedos

Loading

codecov bot commented Oct 14, 2023 •

edited

Loading

stdedos commented Oct 14, 2023

Pierre-Sassoulas left a comment

Pierre-Sassoulas commented Oct 14, 2023

stdedos commented Oct 15, 2023

Pierre-Sassoulas commented Oct 15, 2023 •

edited

Loading

stdedos commented Oct 15, 2023

stdedos commented Oct 15, 2023

stdedos commented Oct 15, 2023

Pierre-Sassoulas commented Oct 15, 2023

Pierre-Sassoulas commented Oct 15, 2023 •

edited

Loading

stdedos commented Oct 15, 2023 •

edited

Loading

Pierre-Sassoulas commented Oct 15, 2023

stdedos commented Oct 15, 2023

Pierre-Sassoulas commented Dec 4, 2023

stdedos commented Dec 19, 2023 •

edited

Loading

Pierre-Sassoulas commented Dec 19, 2023

stdedos left a comment

Pierre-Sassoulas commented Dec 19, 2023

Migrate setup.py to pyproject.toml #8

Migrate setup.py to pyproject.toml #8

Conversation

Pierre-Sassoulas commented Oct 14, 2023 • edited by stdedos Loading

codecov bot commented Oct 14, 2023 • edited Loading

Codecov Report

stdedos commented Oct 14, 2023

Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

Pierre-Sassoulas commented Oct 14, 2023

stdedos commented Oct 15, 2023

Pierre-Sassoulas commented Oct 15, 2023 • edited Loading

stdedos commented Oct 15, 2023

stdedos commented Oct 15, 2023

stdedos commented Oct 15, 2023

Pierre-Sassoulas commented Oct 15, 2023

Pierre-Sassoulas commented Oct 15, 2023 • edited Loading

stdedos commented Oct 15, 2023 • edited Loading

Pierre-Sassoulas commented Oct 15, 2023

stdedos commented Oct 15, 2023

Pierre-Sassoulas commented Dec 4, 2023

stdedos commented Dec 19, 2023 • edited Loading

Pierre-Sassoulas commented Dec 19, 2023

stdedos left a comment

Choose a reason for hiding this comment

Pierre-Sassoulas commented Dec 19, 2023

Pierre-Sassoulas commented Oct 14, 2023 •

edited by stdedos

Loading

codecov bot commented Oct 14, 2023 •

edited

Loading

Pierre-Sassoulas commented Oct 15, 2023 •

edited

Loading

Pierre-Sassoulas commented Oct 15, 2023 •

edited

Loading

stdedos commented Oct 15, 2023 •

edited

Loading

stdedos commented Dec 19, 2023 •

edited

Loading