-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add typing with PyAnnotate
to ./tests
#4950
Add typing with PyAnnotate
to ./tests
#4950
Conversation
Pull Request Test Coverage Report for Build 1197891429
💛 - Coveralls |
For some reason |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good, thank you. There's only this issue with the match change that needs to be addressed.
I think this is now good to go! |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, this is going to help tremendously for putting mypy in place. And it's giving me idea for astroid :)
Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
for more information, see https://pre-commit.ci
If I can find the time I would be willing to start this up for |
I started something for astroid, pylint-dev/astroid#1163, but there will be a lot of work before being able to add mypy. pyannotate had some bug I had to manually fix the configuration json. We could discuss this in detail on the astroid's MR. |
Going to look at pylint-dev/astroid#1163 tomorrow. Is there anything needed for this PR to be merged? |
doc/whatsnew/<current release.rst>
.Description
I thought I would try and see if I could use
pyannote
to do some typing for./pytest
.I have split the changes into commits for each directory, sorry for the size of the PR I think this is about the limit of easy reviewing.