Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove test dependency mypy-extensions #4969

Merged
merged 1 commit into from
Sep 5, 2021
Merged

Remove test dependency mypy-extensions #4969

merged 1 commit into from
Sep 5, 2021

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Sep 5, 2021 •
edited
Loading

Type of Changes

Type
✓ 🔨 Refactoring

Description

pylint already uses typing-extensions. There is no need to add mypy-extensions as well. Ref #4950
https://docs.python.org/3/library/typing.html#typing.NoReturn

/CC: @DanielNoord

@cdce8p cdce8p added dependency Label for github dependabot Maintenance Discussion or action around maintaining pylint or the dev workflow labels Sep 5, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1203418490

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.099%
Totals Coverage Status
Change from base Build 1201318317: 0.0%
Covered Lines: 13234
Relevant Lines: 14215
💛 - Coveralls

@cdce8p cdce8p merged commit 005b7d2 into pylint-dev:main Sep 5, 2021
@cdce8p cdce8p deleted the remove-mypy_extensions branch September 5, 2021 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
dependency Label for github dependabot Maintenance Discussion or action around maintaining pylint or the dev workflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cdce8p @coveralls @Pierre-Sassoulas