Pyreverse: Don't show multiple class association arrows #9055
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #9055 +/- ##
=======================================
Coverage 95.75% 95.75%
=======================================
Files 173 173
Lines 18652 18657 +5
=======================================
+ Hits 17860 17865 +5
Misses 792 792
|
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
I feel like we need to determine what is the strongest association here and show only this one. There's another unrelated bug signaled by Andreas in the original issue (no composition here) that will make the association the only remaining link between those classes, right ?
|
This change is a bit hacky. Rather than sort out why relations are being miscategorized, we just drop any extra arrows if they show up. This is done according to relation precedence, so if there is a composition arrow, we print it and then ignore any subsequent aggregation arrows, since those have lower precedence. This doesn't address how relations are categorized, but it does eliminate the most annoying side effect of the problem, namely too many arrows. |
|
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit 4869dd8 |
There was a problem hiding this comment.
Thanks for yet another fix!
I would be OK with separating the fixes for multiple arrows vs. determining the correct association into distinct PRs.
@nickdrozd and @Pierre-Sassoulas I would leave it to one of you to merge, in case you want to include the fix for the misclassified associations in this PR as well.
Type of Changes
Description
Fixes the multiple-association-arrows bug mentioned in #9045