Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pyreverse: Don't show multiple class association arrows #9055

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Pyreverse: Don't show multiple class association arrows #9055

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3496fe2
Don't show multiple class association arrows
nickdrozd Sep 21, 2023
4869dd8
Update bugfix description
nickdrozd Sep 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions doc/whatsnew/fragments/9045.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Pyreverse doesn't show multiple class association arrows anymore, but only the strongest one.

Refs #9045
5 changes: 5 additions & 0 deletions pylint/pyreverse/writer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import argparse
import itertools
import os
from collections import defaultdict
from collections.abc import Iterable

from astroid import modutils, nodes
Expand Down Expand Up @@ -133,8 +134,10 @@ def write_classes(self, diagram: ClassDiagram) -> None:
rel.to_object.fig_id,
type_=EdgeType.INHERITS,
)
associations: dict[str, set[str]] = defaultdict(set)
# generate associations
for rel in diagram.get_relationships("association"):
associations[rel.from_object.fig_id].add(rel.to_object.fig_id)
self.printer.emit_edge(
rel.from_object.fig_id,
rel.to_object.fig_id,
Expand All @@ -143,6 +146,8 @@ def write_classes(self, diagram: ClassDiagram) -> None:
)
# generate aggregations
for rel in diagram.get_relationships("aggregation"):
if rel.to_object.fig_id in associations[rel.from_object.fig_id]:
continue
self.printer.emit_edge(
rel.from_object.fig_id,
rel.to_object.fig_id,
Expand Down
1 change: 0 additions & 1 deletion tests/pyreverse/functional/class_diagrams/aggregation/fields.mmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,3 @@ classDiagram
P --* D : x
P --* E : x
P --o B : x
P --o C : x