Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport maintenance/3.2.x] Fix consider-using-min-max-builtin #9803

Merged

Conversation

github-actions[bot]
Copy link
Contributor

Backport 6236b91 from #9802.

Fix a false positive for `consider-using-min-max-builtin` when the
assignment target is an attribute.

(cherry picked from commit 6236b91)
@Pierre-Sassoulas Pierre-Sassoulas added this to the 3.2.6 milestone Jul 16, 2024
@Pierre-Sassoulas Pierre-Sassoulas added the False Positive 🦟 A message is emitted but nothing is wrong with the code label Jul 16, 2024
@Pierre-Sassoulas Pierre-Sassoulas enabled auto-merge (squash) July 16, 2024 13:59
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (maintenance/3.2.x@8410f57). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##             maintenance/3.2.x    #9803   +/-   ##
====================================================
  Coverage                     ?   95.81%           
====================================================
  Files                        ?      174           
  Lines                        ?    18854           
  Branches                     ?        0           
====================================================
  Hits                         ?    18065           
  Misses                       ?      789           
  Partials                     ?        0           
Files with missing lines Coverage Δ
pylint/checkers/refactoring/refactoring_checker.py 98.37% <100.00%> (ø)

@Pierre-Sassoulas Pierre-Sassoulas merged commit 1d877de into maintenance/3.2.x Jul 16, 2024
25 checks passed
@Pierre-Sassoulas Pierre-Sassoulas deleted the backport-9802-to-maintenance/3.2.x branch July 16, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
False Positive 🦟 A message is emitted but nothing is wrong with the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants