-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix consider-using-min-max-builtin #9802
Fix consider-using-min-max-builtin #9802
Conversation
Fix a false positive for `consider-using-min-max-builtin` when the assignment target is an attribute.
91a1fe2
to
f9330c5
Compare
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #9802 +/- ##
=======================================
Coverage 95.78% 95.79%
=======================================
Files 174 174
Lines 18880 18902 +22
=======================================
+ Hits 18085 18107 +22
Misses 795 795
|
π€ Effect of this PR on checked open source code: π€ Effect on django:
The following messages are no longer emitted:
Effect on sentry:
The following messages are no longer emitted:
This comment was generated for commit f9330c5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great first contribution, the primer result is a pleasure to see π
Fix a false positive for `consider-using-min-max-builtin` when the assignment target is an attribute. (cherry picked from commit 6236b91)
Type of Changes
Description
Fix a false positive for
consider-using-min-max-builtin
when the assignment target is an attribute.Closes #9800