-
-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve appearance #239
improve appearance #239
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Here is how the spline example looks like for example: https://pymc-examples--239.org.readthedocs.build/en/239/splines/spline.html which is where I have added authors to the post directive to show how it looks like cc @tjburch |
@OriolAbril I really like the look of having authors in the sidebar! Would it be annoying to have a separate tag for original author and then one for supplemental contributors? e.g. in this example, I just fixed some plots - I feel a little bad appearing side-by-side with the original author. Maybe this is a null point, since the contributions are at the end and not worth worrying about though. |
That would mean modifying the ablog extension which is something above my skills |
oof yeah, not worth it. Great as-is then. |
This is not a hard preference, but I would prefer authorship to be at the end of the notebook, and in line with this proposal. I like it better because it has more nuance than displaying the names of everybody who made a contribution, which would put someone who fixed a typo at the same level of someone who created the entire thing. I think this is useful for readers in cases where they want to know who did the main work for a notebook (for example, if they need to quote the notebook, or if they want to get in touch with the author). Also, I think for the purposes of documentation it's not as important to display authorship prominently, so I would leave the sidebar for categories and tags. |
todos:
|
Now realized a bit of info on codeautolink is probably in order. It is a sphinx extension that automatically converts the python objects from the libraries configured on intersphinx-mappings to links to their relevant api pages. It is very new and still needs some tweaks, but it is very active and works perfectly well. Here are some examples form their docs: https://sphinx-codeautolink.readthedocs.io/en/latest/examples.html |
be1427b
to
2356136
Compare
Ready to merge and I'll merge this weekend even without any other approving review. |
@@ -4,16 +4,12 @@ | |||
"cell_type": "markdown", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a typo that was there before.
Also the spline notebook still uses "PyMC3", not sure if you want to change that already.
We'll need to rerun them all with v4, so we can take care of that then. So far I have not updated that anywhere in notebooks, only in readme and templates. |
Work on the overall appearance of the website.
notebooks with the post directive will have this. Partial resolution of Guidance/standardization of "front matter" #200, and it is automated.
be interesting to include authors too as discussed in Standardize authorship attribution #198.
#authors
which should then be set and contain the authorship info, links to the profiles of authors...Make the sidebar scrollable, see Only the toctree section of the left sidebar is scrollable pydata/pydata-sphinx-theme#500This will soon be fixed directly by the theme in a much more pretty way than what I first did here.