-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate pypi release #135
Conversation
I'm not quite understanding the numpy import error here, @ricardoV94 , @lucianopaz , @twiecki maybe you've seen something like this before? It seems like there's no reason numpy would be required for building sdist |
You might be building it the wrong way, maybe a difference between using Have you tried to do it locally? |
@ricardoV94 , after the changes I've introduced now it runs locally without issues, but here still seems to be failing. I'll keep searching for some solution but for now it's going to be guessing game a bit |
I need some help on that, nothing that I try works :/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's give it a try?
* adapted the release setup to mimic one used in pymc-marketing * fixed naming not matching in __init__ * fixing importing error for numpy * fixing command * adding numpy dependency to fix missing numpy error * fixing self import in setup.py * including versioneer, supressing pre-commit for versionner files * fixed build
* adapted the release setup to mimic one used in pymc-marketing * fixed naming not matching in __init__ * fixing importing error for numpy * fixing command * adding numpy dependency to fix missing numpy error * fixing self import in setup.py * including versioneer, supressing pre-commit for versionner files * fixed build Automate pypi release (pymc-devs#135) * adapted the release setup to mimic one used in pymc-marketing * fixed naming not matching in __init__ * fixing importing error for numpy * fixing command * adding numpy dependency to fix missing numpy error * fixing self import in setup.py * including versioneer, supressing pre-commit for versionner files * fixed build fixed test failing due to infinite precision requirement (pymc-devs#153)
As pointed out in #134 by @ricardoV94, pymc-experimental doesn't use the same versioning system as main pymc, so the solution taken from there wouldn't work. This PR contains changes that adopt the solution used in pymc-marketing