Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate pypi release #135

Merged
merged 8 commits into from
Apr 24, 2023
Merged

Conversation

michaelraczycki
Copy link
Collaborator

As pointed out in #134 by @ricardoV94, pymc-experimental doesn't use the same versioning system as main pymc, so the solution taken from there wouldn't work. This PR contains changes that adopt the solution used in pymc-marketing

@michaelraczycki
Copy link
Collaborator Author

I'm not quite understanding the numpy import error here, @ricardoV94 , @lucianopaz , @twiecki maybe you've seen something like this before? It seems like there's no reason numpy would be required for building sdist

@ricardoV94
Copy link
Member

ricardoV94 commented Apr 7, 2023

You might be building it the wrong way, maybe a difference between using pyproject.toml (pymc-marketing) and setup.py (pymc-experimental).

Have you tried to do it locally?

@michaelraczycki
Copy link
Collaborator Author

@ricardoV94 , after the changes I've introduced now it runs locally without issues, but here still seems to be failing. I'll keep searching for some solution but for now it's going to be guessing game a bit

@michaelraczycki
Copy link
Collaborator Author

michaelraczycki commented Apr 11, 2023

I need some help on that, nothing that I try works :/

@michaelraczycki michaelraczycki mentioned this pull request Apr 19, 2023
@ricardoV94 ricardoV94 changed the title adapted the release setup to mimic one used in pymc-marketing Automate pypi release Apr 20, 2023
Copy link
Member

@ricardoV94 ricardoV94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give it a try?

@twiecki twiecki merged commit 24947a0 into pymc-devs:main Apr 24, 2023
michaelraczycki added a commit to michaelraczycki/pymc-experimental that referenced this pull request Apr 27, 2023
* adapted the release setup to mimic one used in pymc-marketing

* fixed naming not matching in __init__

* fixing importing error for numpy

* fixing command

* adding numpy dependency to fix missing numpy error

* fixing self import in setup.py

* including versioneer, supressing pre-commit for versionner files

* fixed build
michaelraczycki added a commit to michaelraczycki/pymc-experimental that referenced this pull request Apr 27, 2023
* adapted the release setup to mimic one used in pymc-marketing

* fixed naming not matching in __init__

* fixing importing error for numpy

* fixing command

* adding numpy dependency to fix missing numpy error

* fixing self import in setup.py

* including versioneer, supressing pre-commit for versionner files

* fixed build

Automate pypi release (pymc-devs#135)

* adapted the release setup to mimic one used in pymc-marketing

* fixed naming not matching in __init__

* fixing importing error for numpy

* fixing command

* adding numpy dependency to fix missing numpy error

* fixing self import in setup.py

* including versioneer, supressing pre-commit for versionner files

* fixed build

fixed test failing due to infinite precision requirement (pymc-devs#153)
@michaelraczycki michaelraczycki deleted the release_fixes branch July 5, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants