fixed test failing due to infinite precision requirement #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twiecki
approved these changes
Apr 27, 2023
michaelraczycki
added a commit
to michaelraczycki/pymc-experimental
that referenced
this pull request
Apr 27, 2023
michaelraczycki
added a commit
to michaelraczycki/pymc-experimental
that referenced
this pull request
Apr 27, 2023
* adapted the release setup to mimic one used in pymc-marketing * fixed naming not matching in __init__ * fixing importing error for numpy * fixing command * adding numpy dependency to fix missing numpy error * fixing self import in setup.py * including versioneer, supressing pre-commit for versionner files * fixed build Automate pypi release (pymc-devs#135) * adapted the release setup to mimic one used in pymc-marketing * fixed naming not matching in __init__ * fixing importing error for numpy * fixing command * adding numpy dependency to fix missing numpy error * fixing self import in setup.py * including versioneer, supressing pre-commit for versionner files * fixed build fixed test failing due to infinite precision requirement (pymc-devs#153)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test was failing because the result was not equal up to 10+ digit, I assumed that 6 digit precision should be good enough in this case, now the test is passing