-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split floatX tests into their own CI job #5626
Comments
I would definitely remove test_distributions from float32 tests. Those xfails are not informative of anything because they arise from comparing with scipy methods that are always computed on float64 |
Some tests I think make sense parametrizing with both floatX: pymc/pymc/tests/test_mixture.py Line 662 in b895e40
pymc/pymc/tests/test_distributions_random.py Lines 1577 to 1581 in b895e40
Line 317 in b895e40
Line 336 in b895e40
Probably There should be also a This list is pretty ad hoc though |
Running this on Windows indicates a previously unknown... behavior.
Also for
|
Currently our CI has a
floatX
job matrix on Ubuntu and Windows, running each set of tests with both float32 and float64.But there are just a handful of tests where floatX actually makes a difference.
Only these tests should run with a floatX job matrix, thereby dramatically reducing total CI runtime.
The following screenshot is an incomplete list of candidates:
The text was updated successfully, but these errors were encountered: