-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run float32 jobs separately #5630
Merged
michaelosthege
merged 3 commits into
pymc-devs:main
from
michaelosthege:splice-floatx-jobs
Mar 21, 2022
Merged
Run float32 jobs separately #5630
michaelosthege
merged 3 commits into
pymc-devs:main
from
michaelosthege:splice-floatx-jobs
Mar 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelosthege
force-pushed
the
splice-floatx-jobs
branch
from
March 20, 2022 13:54
13fe4d1
to
359d3fe
Compare
Codecov Report
@@ Coverage Diff @@
## main #5630 +/- ##
==========================================
- Coverage 87.63% 86.26% -1.38%
==========================================
Files 76 76
Lines 13717 13723 +6
==========================================
- Hits 12021 11838 -183
- Misses 1696 1885 +189
|
michaelosthege
force-pushed
the
splice-floatx-jobs
branch
2 times, most recently
from
March 20, 2022 18:46
8ed69b0
to
1c27493
Compare
ricardoV94
force-pushed
the
splice-floatx-jobs
branch
from
March 21, 2022 13:01
1c27493
to
5677646
Compare
ricardoV94
approved these changes
Mar 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed a change that should fix the SMC tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will save a lot of CI resources.
For tests that should run with either floatX setting,
aesara.change_flags
can be used as seen intest_types.py
.Initially I wanted to parametrize the float32 job across Ubuntu & Windows, but the different shells require different syntax in the YAML. The best way to unify that would probably to outsource the
pytest
commands andtest-subset
into a non-YAML file, but I don't have time for that right now.CI time reduced to ~3h45m 🎉
Closes #5626