Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run float32 jobs separately #5630

Merged
merged 3 commits into from
Mar 21, 2022

Conversation

michaelosthege
Copy link
Member

@michaelosthege michaelosthege commented Mar 20, 2022

This change will save a lot of CI resources.

For tests that should run with either floatX setting, aesara.change_flags can be used as seen in test_types.py.

Initially I wanted to parametrize the float32 job across Ubuntu & Windows, but the different shells require different syntax in the YAML. The best way to unify that would probably to outsource the pytest commands and test-subset into a non-YAML file, but I don't have time for that right now.

CI time reduced to ~3h45m 🎉

Closes #5626

@codecov
Copy link

codecov bot commented Mar 20, 2022

Codecov Report

Merging #5630 (5677646) into main (b895e40) will decrease coverage by 1.37%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5630      +/-   ##
==========================================
- Coverage   87.63%   86.26%   -1.38%     
==========================================
  Files          76       76              
  Lines       13717    13723       +6     
==========================================
- Hits        12021    11838     -183     
- Misses       1696     1885     +189     
Impacted Files Coverage Δ
pymc/distributions/simulator.py 87.58% <100.00%> (+0.08%) ⬆️
pymc/sampling_jax.py 0.00% <0.00%> (-96.97%) ⬇️
pymc/distributions/logprob.py 96.33% <0.00%> (+0.17%) ⬆️
pymc/parallel_sampling.py 87.70% <0.00%> (+0.99%) ⬆️

@michaelosthege michaelosthege force-pushed the splice-floatx-jobs branch 2 times, most recently from 8ed69b0 to 1c27493 Compare March 20, 2022 18:46
@michaelosthege michaelosthege marked this pull request as ready for review March 20, 2022 19:21
Copy link
Member

@ricardoV94 ricardoV94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a change that should fix the SMC tests

@michaelosthege
Copy link
Member Author

The coverage check for 6af5104 was good and in the last commit 5677646 I don't see how it could affect sampling_jax.py coverage.

Let's ship it :)

@michaelosthege michaelosthege merged commit 436f94a into pymc-devs:main Mar 21, 2022
@michaelosthege michaelosthege deleted the splice-floatx-jobs branch March 21, 2022 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split floatX tests into their own CI job
2 participants