Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mypy from pre-commit #5907

Closed
ricardoV94 opened this issue Jun 18, 2022 · 1 comment · Fixed by #6186
Closed

Remove mypy from pre-commit #5907

ricardoV94 opened this issue Jun 18, 2022 · 1 comment · Fixed by #6186
Labels
Github CI/CD pre-commit request discussion

Comments

@ricardoV94
Copy link
Member

pre-commit is too slow since we introduced mypy in it, to the point I have disabled it and have to call it manually before pushing (if I remember to)

I suggest we add it as a test and remove it from pre-commit.
@michaelosthege
Copy link
Member

Inside the pre-commit.yml it could run as its own job

@michaelosthege michaelosthege mentioned this issue Jul 3, 2022
Closed
michaelosthege added a commit that referenced this issue Oct 5, 2022
@michaelosthege
Run mypy outside of pre-commit in its own job
331553c 
Closes #5907
@michaelosthege michaelosthege mentioned this issue Oct 5, 2022
Merged
5 tasks
michaelosthege added a commit that referenced this issue Oct 5, 2022
@michaelosthege
Run mypy outside of pre-commit in its own job
f4c5cd7 
Closes #5907
michaelosthege added a commit that referenced this issue Oct 5, 2022
@michaelosthege
Run mypy outside of pre-commit in its own job
d96a518 
Closes #5907
michaelosthege added a commit that referenced this issue Oct 5, 2022
@michaelosthege
Run mypy outside of pre-commit
4f373cb 
Closes #5907
michaelosthege added a commit that referenced this issue Oct 5, 2022
@michaelosthege
Run mypy outside of pre-commit
4f0c169 
Closes #5907
michaelosthege added a commit that referenced this issue Oct 5, 2022
@michaelosthege
Run mypy outside of pre-commit
abe7cdd 
Closes #5907
@maresb maresb mentioned this issue Oct 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Github CI/CD pre-commit request discussion
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Run mypy outside of pre-commit in its own job pymc-devs/pymc
2 participants
@michaelosthege @ricardoV94