Run mypy outside of pre-commit in its own job #6186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelosthege
force-pushed
the
issue-5907
branch
2 times, most recently
from
f4c5cd7 to
d96a518
Compare
michaelosthege
changed the title
michaelosthege
force-pushed
the
issue-5907
branch
from
d96a518 to
4f373cb
Compare
michaelosthege
force-pushed
the
issue-5907
branch
from
4f373cb to
4f0c169
Compare
ricardoV94
changed the title
ricardoV94
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5907
What is this PR about?
Speeding up pre-commit by running
mypyin a dedicated job in GitHub Actions.The job definition is a stripped-down version of the one in the
tests.ymlaction.Checklist
Major / Breaking Changes
Bugfixes / New features
Docs / Maintenance
mypynow runs as its own job on GitHub Actions and is no longer part of the pre-commit steps.