Rectify Return type hint

[Dhruvanshu-Joshi]

Description

Take a look at the code snippet below:

pymc/pymc/logprob/binary.py

Lines 42 to 44 in f67ff8b

	def find_measurable_comparisons(
	fgraph: FunctionGraph, node: Node
	) -> Optional[List[MeasurableComparison]]:

Here, the return type hint is wrong. MeasurableComparision is an Op, but what is returned are TensorVariables whose node has that Op.

This needs to be rectified for all the functions which intend to find a measurable op.

CC @ricardoV94 @larryshamalama

[5hv5hvnk]

@larryshamalama
Just to be sure a fix would be returning the node or changing the return data type?

[larryshamalama]

@larryshamalama Just to be sure a fix would be returning the node or changing the return data type?

Yes, I believe just changing the return data type would be good. Sorry, it looks like I missed your question from a while ago...

[vivek-anand-singh]

It seems like an easy fix. We just need to change variable "MeasurableComparison" in return type to variable "TensorVariable".

Here is the code modifications:

def find_measurable_comparisons(
    fgraph: FunctionGraph, node: Node
) -> Optional[List[TensorVariable]]:

Could you please verify if this is corrent? I can open a pull request for it.

[larryshamalama]

It seems like an easy fix. We just need to change variable "MeasurableComparison" in return type to variable "TensorVariable".

Here is the code modifications:

def find_measurable_comparisons(
    fgraph: FunctionGraph, node: Node
) -> Optional[List[TensorVariable]]:

Could you please verify if this is corrent? I can open a pull request for it.

That should be the case! And that would be great :)