-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rectify return type hints in logprob module rewrites #7125
Conversation
@larryshamalama and @ricardoV94 please look into this issue. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7125 +/- ##
==========================================
+ Coverage 90.17% 90.20% +0.02%
==========================================
Files 101 101
Lines 16932 16961 +29
==========================================
+ Hits 15269 15299 +30
+ Misses 1663 1662 -1
|
@larryshamalama and @ricardoV94 why did some tests failed.
It shows this file failed but I didn't even change this file. |
@AryanNanda17 this issue is already been worked by another contributor in #7013 We will give priority to the first one as the contributor mentioned he still wants to work on it |
@larryshamalama You could have told me this when I raised this issue #7093 but I kept working on it to figure out what was going wrong. |
Unfortunately, I missed the duplicated work when you opened that first PR. I am sorry. The info about related PRs should show up in the original issue, but I don't usually check if a PR is already linked when someone opens a new one. |
I see @larryshamalama mentioned an option of adding people as co-authors. We can also do that, specially since this PR is already complete it seems. I'll check the unrelated failing test. |
@ricardoV94 any idea why the tests failed? |
It's failing elsewhere, not this PR's fault |
@ricardoV94 and @larryshamalama thanks for looking into the issue. |
We're looking into the failed test in #7136 |
Co-authored-by: Vivek Anand Singh <17vivekanandsingh@gmail.com>
Description
Related Issue
Checklist
Type of change
The return type hint is wrong in many files. MeasurableComparision is an Op, but what is returned are TensorVariables whose node has that Op. This needs to be rectified for all the functions which intend to find a measurable op.
📚 Documentation preview 📚: https://pymc--7125.org.readthedocs.build/en/7125/