Rectify Return type hint

[vivek-anand-singh]

Fixes #6811

Rectify Return type hint for find_measurable_comparisons

---

📚 Documentation preview 📚: https://pymc--7013.org.readthedocs.build/en/7013/

[welcome]

💖 Thanks for opening this pull request! 💖 The PyMC community really appreciates your time and effort to contribute to the project. Please make sure you have read our Contributing Guidelines and filled in our pull request template to the best of your ability.

[larryshamalama]

Hi @vivek-anand-singh, thanks for your PR! Apologies for getting back to you late. Please don't hesitate to ping me (or any devs you want to review your PR) via the comment section next time :)

There are some other places where we would need to rectify type hints. Would you like to include those changes in this PR? I found the occurrences for your convenience

pymc/pymc/logprob/checks.py

Line 66 in f8b142a

def find_measurable_specify_shapes(fgraph, node) -> Optional[List[MeasurableSpecifyShape]]:

pymc/pymc/logprob/checks.py

Line 119 in f8b142a

def find_measurable_check_and_raise(fgraph, node) -> Optional[List[MeasurableCheckAndRaise]]:

pymc/pymc/logprob/cumsum.py

Line 80 in f8b142a

def find_measurable_cumsums(fgraph, node) -> Optional[List[MeasurableCumsum]]:

pymc/pymc/logprob/censoring.py

Line 65 in f8b142a

def find_measurable_clips(fgraph: FunctionGraph, node: Node) -> Optional[List[MeasurableClip]]:

pymc/pymc/logprob/censoring.py

Line 160 in f8b142a

def find_measurable_roundings(fgraph: FunctionGraph, node: Node) -> Optional[List[MeasurableRound]]:

pymc/pymc/logprob/binary.py

Line 136 in f8b142a

def find_measurable_bitwise(fgraph: FunctionGraph, node: Node) -> Optional[List[MeasurableBitwise]]:

pymc/pymc/logprob/tensor.py

Lines 200 to 202 in f8b142a

	def find_measurable_stacks(
	fgraph, node
	) -> Optional[List[Union[MeasurableMakeVector, MeasurableJoin]]]:

When you would like for me to have a look again, you can request my revision around the top right of this PR

[vivek-anand-singh]

pymc/pymc/logprob/tensor.py

Lines 200 to 202 in f8b142a

	def find_measurable_stacks(
	fgraph, node
	) -> Optional[List[Union[MeasurableMakeVector, MeasurableJoin]]]:

Hi @larryshamalama Thanks for the feedback ! should we change both MeasurableMakeVectorand MeasurableJoin to TensorVariable?

[larryshamalama]

Hi @vivek-anand-singh, so sorry for the delay, holidays, travels and studies came in the way of my OSS involvement... You can perhaps just do:

def find_measurable_stacks( 
     fgraph, node 
 ) -> Optional[List[TensorVariable]]: 

FYI: this issue is being worked on in #7093. Because time has passed (which is my fault), I will add both of you as co-authors to whichever PR gets merged.

[vivek-anand-singh]

Thanks for the response, Actually my exams are going on so I will do this after 2 days

[larryshamalama]

#7093 is pretty much completed, so we are probably going to merge that PR and close this one. Again, apologies for the mix of delays; in principle, we should prioritize preceding PRs but there was a miscommunication here. We can add you as a co-author when merging the other PR.

[ricardoV94]

Added as a co-author in fb1c48f

Sorry for the trouble!