Fix VI test not skipping in Windows

[ricardoV94]

Description

The test test_fit_start[SVGD-mini] stopped raising a NotImplementedInferenceError in Windows recently.

pymc/tests/variational/test_inference.py

Lines 206 to 210 in f8b19a5

	try:
	with warn_ctxt:
	trace = inference.fit(n=0).sample(10000)
	except NotImplementedInference as e:
	pytest.skip(str(e))

It should come from

pymc/pymc/variational/operators.py

Lines 145 to 148 in 2051d0b

	if _known_scan_ignored_inputs([self.approx.model.logp()]):
	raise NotImplementedInference(
	"SVGD does not currently support Minibatch or Simulator RV"
	)

It still works correctly on Linux?

Link to failing test:
https://github.com/pymc-devs/pymc/actions/runs/7783900052/job/21223348962?pr=7136

Related Issue

• Closes #
• Related to #

Checklist

• Checked that the pre-commit linting/style checks pass
• Included tests that prove the fix is effective or that the new feature works
• Added necessary documentation (docstrings and/or example notebooks)
• If you are a pro: each commit corresponds to a relevant logical change

Type of change

• New feature / enhancement
• Bug fix
• Documentation
• Maintenance
• Other (please specify):

---

📚 Documentation preview 📚: https://pymc--7136.org.readthedocs.build/en/7136/

[codecov]

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6554683) 52.44% compared to head (aef772d) 67.58%.
Report is 1 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #7136       +/-   ##
===========================================
+ Coverage   52.44%   67.58%   +15.13%     
===========================================
  Files          85      101       +16     
  Lines       16441    16956      +515     
===========================================
+ Hits         8623    11460     +2837     
+ Misses       7818     5496     -2322     

Files	Coverage Δ
pymc/variational/operators.py	55.31% <0.00%> (-1.21%)	⬇️

... and 58 files with indirect coverage changes

[aerubanov]

@ricardoV94 I try to run this test locally on Linux. It is fails when I use pytest==8.0 and skipped with pytest==7.*

[ricardoV94]

Thanks @aerubanov that's some nice info. Could you dig anything that changed with pytest 8.0?

[aerubanov]

Yeah, will try to find something relevant for this issue

[aerubanov]

Looks like in pytest 7 missing warning were ignored if some exception was raised, but pytest 8 checking them and that`s why this test fails. Relevant PR: pytest-dev/pytest#11129

[ricardoV94]

Great, how should we fix it though :D?

[aerubanov]

@ricardoV94 I see two options:

• Do not use pytest.warn() here and check for warning manualy
• Keep list of parameters for which NotImplementedInference should be raised and call pytest.skip() before interface.fit()

[ricardoV94]

First seems slightly better? Do you want to push on this PR? If for some reason you don't have permissions you can also just open a new one

[aerubanov]

Yeah, looks like first will require less changes in the future. Will try to implement it.

[aerubanov]

@ricardoV94 could you please take a look #7144?