Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create dedicated environment YML for Windows #4779

Merged
merged 1 commit into from
Jun 19, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
with:
path: ~/conda_pkgs_dir
key: ${{ runner.os }}-conda-${{ env.CACHE_NUMBER }}-${{
hashFiles('conda-envs/environment-dev-py38.yml') }}
hashFiles('conda-envs/windows-environment-dev-py38.yml') }}
- name: Cache multiple paths
uses: actions/cache@v2
env:
Expand All @@ -48,7 +48,7 @@ jobs:
with:
activate-environment: pymc3-dev-py38
channel-priority: strict
environment-file: conda-envs/environment-dev-py38.yml
environment-file: conda-envs/windows-environment-dev-py38.yml
use-only-tar-bz2: true # IMPORTANT: This needs to be set for caching to work properly!
- name: Install-pymc3
run: |
Expand Down
26 changes: 26 additions & 0 deletions conda-envs/windows-environment-dev-py38.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
name: pymc3-dev-py38
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as the other PR. Just add a docstring explaining the nuances of "what does windows do different"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deferred to #4786

channels:
- conda-forge
- defaults
dependencies:
# base dependencies (see install guide for Windows)
- h5py>=2.7
- libpython
- mkl-service
- m2w64-toolchain
- numba
- pip
- python=3.8
- python-graphviz
- scipy
# Extra stuff for dev, testing and docs build
- ipython>=7.16
- nbsphinx>=0.4
- numpydoc>=0.9
- pre-commit>=2.8.0
- pytest-cov>=2.5
- pytest>=3.0
- recommonmark>=0.4
- sphinx-autobuild>=0.7
- sphinx>=1.5
- watermark
12 changes: 11 additions & 1 deletion scripts/generate_pip_deps_from_conda.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,17 @@

import yaml

EXCLUDE = {"python", "libblas", "mkl-service", "python-graphviz"}
EXCLUDE = {
"pip",
"python",
"libblas",
"libpython",
"m2w64-toolchain",
"mkl-service",
"numba",
"scipy",
"python-graphviz",
}
RENAME = {}


Expand Down